docs: update contributing instructions #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix inline heading links * Moved test pre-requisites to top of Testing section * Update `make ci` => `make test` * Removes aruba init command, as it seemed to add duplicate line to Gemfile
thisislawatts
commented
Feb 4, 2024
|
|
||
| ```bash | ||
| $ gem install bundler # if necessary | ||
| $ aruba init --test-framework cucumber | ||
| $ gem install bundler:2.2.31 # if necessary |
There was a problem hiding this comment.
Added the specific version here, otherwise the install complained about me using a more recent recent version of bundler than the one used to generate the lockfile. I could have regenerated the lockfile but without 100% passing tests that seemed unsafe.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the tool @jdkato, I have been able to get almost everything passing
116 scenarios (2 failed, 114 passed), using the documentation. I've made a few small tweaks which may help other people less familiar with ruby.make ci=>make test