Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General and performance tweaks #614

Merged
merged 22 commits into from
May 7, 2018
Merged

General and performance tweaks #614

Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6f13f97
Use mutating loop instead of array_map
aidantwoods Apr 8, 2018
f232702
No need to unset if not set
aidantwoods Apr 8, 2018
90ad738
General readability
aidantwoods Apr 8, 2018
70f5c02
Use non-nestable values as keys for O(1) lookup
aidantwoods Apr 8, 2018
dc5cf87
The AST has high complexity here (and so traversal is hard anyway)
aidantwoods Apr 8, 2018
d6e306d
Optimise commonly used regexes to fail fast
aidantwoods Apr 8, 2018
d4f1ac4
String interpolation is slightly faster than concat
aidantwoods Apr 8, 2018
107223d
Avoid recomputation
aidantwoods Apr 8, 2018
b42add3
Make some regexes possesive
aidantwoods Apr 8, 2018
2faba6f
Remove unneeded complete function
aidantwoods Apr 8, 2018
c45e419
Use standard library over while loop
aidantwoods Apr 8, 2018
3ea0814
Remove use of array
aidantwoods Apr 8, 2018
b53aa74
Use standard library function
aidantwoods Apr 8, 2018
e74a5bd
In theory PHP stores the length of strings, so looking this up should…
aidantwoods Apr 9, 2018
d2dd736
Remove regex from fenced code block
aidantwoods Apr 9, 2018
7e15d99
Remove regex from block rule
aidantwoods Apr 9, 2018
450a74f
More expensive statement last
aidantwoods Apr 9, 2018
726d4ef
Sanity checks before starting regex engine
aidantwoods Apr 9, 2018
88a3f31
Rewrite as one statement
aidantwoods Apr 12, 2018
3e70819
Readability improvements, thanks @PhrozenByte
aidantwoods Apr 12, 2018
7f4318d
PHP 5.3 == 💩
aidantwoods Apr 12, 2018
a9764ec
Remove complex string interpolation expressions
aidantwoods Apr 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading