-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this branch is a sub-branch of |
erwindon
force-pushed
the
timeout
branch
6 times, most recently
from
July 7, 2019 11:38
c82c278
to
85709f3
Compare
@lostsnow @dawidmalina @elipsion |
Try this: mochajs/mocha#2025? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
When there is a session timeout, most API calls end with "401 Unauthorized".
SaltGUI carries on because it may not have access to a single API call (or range of API calls).
Describe the solution you'd like
When a 401 is received, the current time should be compared with the session-end time as received at login. When the current time is past that, it is safe to conclude that the whole session has expired. The logout procedure should be triggered so that cached information is removed and the screen reverts to the login screen.
Function
isAuthenticated
can be retired.closes #251