Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout #254

Merged
merged 10 commits into from
Jul 14, 2019
Merged

Timeout #254

merged 10 commits into from
Jul 14, 2019

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Jul 6, 2019

Is your feature request related to a problem? Please describe.
When there is a session timeout, most API calls end with "401 Unauthorized".
SaltGUI carries on because it may not have access to a single API call (or range of API calls).

Describe the solution you'd like
When a 401 is received, the current time should be compared with the session-end time as received at login. When the current time is past that, it is safe to conclude that the whole session has expired. The logout procedure should be triggered so that cached information is removed and the screen reverts to the login screen.
Function isAuthenticated can be retired.

closes #251

@erwindon
Copy link
Owner Author

erwindon commented Jul 6, 2019

Note that this branch is a sub-branch of options (so it cannot be merged now).

@erwindon erwindon force-pushed the timeout branch 6 times, most recently from c82c278 to 85709f3 Compare July 7, 2019 11:38
@erwindon
Copy link
Owner Author

@lostsnow @dawidmalina @elipsion
Do you have any experience with nightmare?
(i.e. the functional regression-test that runs as part of runtests.sh)
The regression test now fails and I cannot find how to get the proper error message...

@lostsnow
Copy link
Contributor

Try this: mochajs/mocha#2025?

@erwindon erwindon merged commit 1670f2d into master Jul 14, 2019
@erwindon erwindon deleted the timeout branch July 20, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After errors due to session-timeout, SaltGUI should return to login screen
2 participants