Skip to content

Commit

Permalink
[actions] make workflows more consistent
Browse files Browse the repository at this point in the history
  • Loading branch information
ljharb committed Dec 28, 2020
1 parent 1fcd52c commit 3347993
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/node-4+.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ jobs:
needs: [latest, minors]
runs-on: ubuntu-latest
steps:
- run: 'echo tests completed'
- run: 'echo tests completed'
5 changes: 4 additions & 1 deletion .github/workflows/node-iojs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
command: 'tests-only'
skip-ls-check: true

minors:
needs: [matrix, latest]
name: 'non-latest minors'
Expand All @@ -46,10 +48,11 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
command: 'tests-only'
skip-ls-check: true

node:
name: 'io.js'
needs: [latest, minors]
runs-on: ubuntu-latest
steps:
- run: 'echo tests completed'
- run: 'echo tests completed'
3 changes: 1 addition & 2 deletions .github/workflows/node-pretest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ jobs:
pretest:
runs-on: ubuntu-latest


steps:
- uses: actions/checkout@v2
- uses: ljharb/actions/node/run@main
Expand All @@ -24,4 +23,4 @@ jobs:
name: 'npm install && npm run posttest'
with:
node-version: 'lts/*'
command: 'posttest'
command: 'posttest'
5 changes: 4 additions & 1 deletion .github/workflows/node-zero.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
node-version: ${{ matrix.node-version }}
command: 'tests-only'
cache-node-modules-key: node_modules-${{ github.workflow }}-${{ github.action }}-${{ github.run_id }}
skip-ls-check: true

unstable:
needs: [matrix, stable]
name: 'unstable minors'
Expand All @@ -46,10 +48,11 @@ jobs:
node-version: ${{ matrix.node-version }}
command: 'tests-only'
cache-node-modules-key: node_modules-${{ github.workflow }}-${{ github.action }}-${{ github.run_id }}
skip-ls-check: true

node:
name: 'node 0.x'
needs: [stable, unstable]
runs-on: ubuntu-latest
steps:
- run: 'echo tests completed'
- run: 'echo tests completed'
2 changes: 0 additions & 2 deletions .github/workflows/require-allow-edits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,3 @@ jobs:

steps:
- uses: ljharb/require-allow-edits@main
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

0 comments on commit 3347993

Please sign in to comment.