Match the spec properly #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes es-shims#1 and es-shims#2.
| @@ -79,12 +83,30 @@ test('shims properly', function (t) { | |||
| st.end(); | |||
| }); | |||
|
|
|||
| t.test('has the correct descriptor', function (st) { | |||
| st.equal(); | |||
There was a problem hiding this comment.
Whoops – fixed :)
|
Can you separate this into three PRs? One for the throwing behavior, one for configurability, and one for being used generically? That way I can merge the first immediately. |
| t.test('throws properly', function (st) { | ||
| var nonObjects = ['', false, true, 42, NaN, null, undefined]; | ||
| st.plan(nonObjects.length); | ||
| nonObjects.forEach(function (nonObject) { | ||
| st.throws(function () { RegExp.prototype.flags.call(nonObject); }, TypeError); | ||
| st.throws(function () { testGenericFlags(nonObject); }, TypeError); |
There was a problem hiding this comment.
This isn't necessary; the original is functionally equivalent and imo reads more clearly.
There was a problem hiding this comment.
It is necessary: paulmillr/es6-shim#310 (comment) RegExp.prototype.flags.call({}) throws TypeError: call is not a function since flags is a getter.
There was a problem hiding this comment.
ahhhh that makes sense. Thanks for clarifying.
ljharb
added a commit
that referenced
this pull request
Dec 13, 2014
Match the spec properly: throw when not an object; make getter generic.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1 and #2.