Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize callable (and newable) signatures #715

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

kevinbarabash
Copy link
Collaborator

@kevinbarabash kevinbarabash commented Oct 2, 2023

Call and constructor signatures should be generalized just like any other function signature.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #715 (2b1b03f) into main (4f0ee9b) will increase coverage by 0.53%.
The diff coverage is 90.27%.

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
+ Coverage   85.34%   85.87%   +0.53%     
==========================================
  Files          61       61              
  Lines       11849    11843       -6     
==========================================
+ Hits        10112    10170      +58     
+ Misses       1737     1673      -64     
Files Coverage Δ
crates/escalier_ast/src/type_ann.rs 100.00% <ø> (ø)
crates/escalier_hm/src/folder.rs 94.11% <100.00%> (+3.80%) ⬆️
crates/escalier_hm/src/types.rs 88.00% <100.00%> (+3.43%) ⬆️
crates/escalier_hm/src/unify.rs 86.56% <100.00%> (ø)
crates/escalier_interop/src/parse.rs 91.65% <100.00%> (+0.06%) ⬆️
crates/escalier_codegen/src/d_ts.rs 82.54% <0.00%> (-0.13%) ⬇️
crates/escalier_hm/src/infer.rs 94.27% <96.92%> (+2.56%) ⬆️
crates/escalier_hm/src/visitor.rs 43.36% <87.50%> (+6.77%) ⬆️
crates/escalier_parser/src/type_ann_parser.rs 95.53% <81.81%> (-0.46%) ⬇️
crates/escalier_interop/src/util.rs 88.95% <37.50%> (-1.91%) ⬇️

@kevinbarabash kevinbarabash merged commit 339441e into main Oct 2, 2023
6 checks passed
@kevinbarabash kevinbarabash deleted the generalize_callables branch October 2, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant