- Updated library to null-safety #21
Conversation
AlexBacich
commented
Apr 25, 2021
AlexBacich
commented
- Fixed tests
- Fixed example with tests
- Overall cleanup and small bugfix
- Fixed tests - Fixed example with tests - Overall cleanup and small bugfix
|
@escamoteur , please review and publish. I've fixed and run all unit \ functional tests in the library and example so that might be good to go without thorough review. |
|
could you check if your PR still works with the latest now safe version of RX command 6.0.0-null-safety.3? |
|
Done, all tests passed, updated PR |
lib/src/rx_command_builder.dart
Outdated
| class RxCommandBuilder<R> extends StatelessWidget { | ||
| final Stream<CommandResult<dynamic, R>> commandResults; | ||
| final RxBuilder<R>? dataBuilder; | ||
| final ErrorBuilder<Exception>? errorBuilder; |
There was a problem hiding this comment.
Wouldn't it make sense to pass the full CommandError to the errorBuilder ? On that note I just wonder if not all error handlers/builders should be defined to expect CommandErrors.
I know this would be a major breaking change, but the ability to access the paramData is a huge advantage to display meaningful error messages
There was a problem hiding this comment.
This makes sense, didn't see it before. I think will use it.
There was a problem hiding this comment.
Updated. I don't think we should define CommandErrors in all builders as this one is specific to rxCommand.
There was a problem hiding this comment.
Please review. all changes.
- Updated rx_command_builder.dart: made it work with CommandError
|
@escamoteur , ping |
|
did you also update the readme? |
|
Good point. I will update with the next update. |
|
Just fixed the other open issue with #19 and pushed V4.0.1 |
