Skip to content

Commit

Permalink
test(core): assert installation does not output errors
Browse files Browse the repository at this point in the history
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
  • Loading branch information
neilime committed Aug 30, 2024
1 parent d1a7b1e commit 70b6308
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions packages/core/src/core.spec.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,12 @@ describe(`E2E - ${packageToTest}`, () => {
afterEach(() => shouldCleanupAfterTest && deleteFolderRecursive(testSimpleProjectDir));

it(`Installs ${packageToTest} package`, async () => {
const {
code: installPackageCode,
// stderr: installPackageStderr
} = await exec(testSimpleProjectDir, `yarn add --dev "file:/${packagePath}"`);
const { code: installPackageCode, stderr: installPackageStderr } = await exec(
testSimpleProjectDir,
`yarn add --dev "file:/${packagePath}"`
);

// FIXME: installation ouput warnings due to dependencies
// expect(installPackageStderr).toBeFalsy();
expect(installPackageStderr).toBeFalsy();
expect(installPackageCode).toBe(0);

const {
Expand Down Expand Up @@ -114,11 +113,12 @@ describe(`E2E - ${packageToTest}`, () => {
afterEach(() => shouldCleanupAfterTest && deleteFolderRecursive(testMonorepoProjectDir));

it(`Installs ${packageToTest} package`, async () => {
const {
code: installPackageCode,
// stderr: installPackageStderr
} = await exec(testMonorepoProjectDir, `yarn add -W --dev "file:${packagePath}"`);
// expect(installPackageStderr).toBeFalsy();
const { code: installPackageCode, stderr: installPackageStderr } = await exec(
testMonorepoProjectDir,
`yarn add -W --dev "file:${packagePath}"`
);

expect(installPackageStderr).toBeFalsy();
expect(installPackageCode).toBe(0);

const {
Expand Down

0 comments on commit 70b6308

Please sign in to comment.