Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support nx config for commitlint #1332

Merged

Conversation

neilime
Copy link
Contributor

@neilime neilime commented Jun 17, 2024

No description provided.

@neilime neilime linked an issue Jun 17, 2024 that may be closed by this pull request
@neilime neilime self-assigned this Jun 17, 2024
@github-actions github-actions bot closed this Aug 24, 2024
@neilime neilime reopened this Aug 28, 2024
@neilime neilime force-pushed the 1300-support-commitlintconfig-nx-scopes-if-project-is-using-nx branch from 6417d03 to 50e1e79 Compare August 28, 2024 07:57
@escemi-tech escemi-tech deleted a comment from github-actions bot Aug 28, 2024
@neilime neilime added the enhancement New feature or request label Aug 28, 2024
@neilime neilime force-pushed the 1300-support-commitlintconfig-nx-scopes-if-project-is-using-nx branch from 50e1e79 to 8ab17fb Compare August 28, 2024 09:24
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 85.39326% with 13 lines in your changes missing coverage. Please review.

Project coverage is 86.94%. Comparing base (2c90538) to head (01df03b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/core/src/services/PackageManagerService.ts 87.14% 9 Missing ⚠️
...tall/migrations/20240617094000-config-nx-scopes.ts 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
- Coverage   87.26%   86.94%   -0.32%     
==========================================
  Files          27       28       +1     
  Lines         573      659      +86     
  Branches       80      112      +32     
==========================================
+ Hits          500      573      +73     
- Misses         73       79       +6     
- Partials        0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neilime neilime force-pushed the 1300-support-commitlintconfig-nx-scopes-if-project-is-using-nx branch 3 times, most recently from bf35623 to b4caebc Compare August 29, 2024 14:25
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
@neilime neilime force-pushed the 1300-support-commitlintconfig-nx-scopes-if-project-is-using-nx branch from b4caebc to 01df03b Compare August 29, 2024 14:27
@neilime neilime merged commit 6a795ed into main Aug 29, 2024
8 checks passed
@neilime neilime deleted the 1300-support-commitlintconfig-nx-scopes-if-project-is-using-nx branch August 29, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support @commitlint/config-nx-scopes if project is using nx
1 participant