LLVM 12 updates. #86
LLVM 12 updates. #86
Conversation
src/LLVM_intrinsics.jl
Outdated
| @@ -775,8 +775,9 @@ for (fs, c) in zip([HORZ_REDUCTION_OPS_FLOAT, HORZ_REDUCTION_OPS_INT], | |||
| [FloatingTypes, IntegerTypes]) | |||
| for f in fs | |||
| f_red = Symbol("reduce_", f) | |||
| ff_base = Base.libllvm_version < v"12" ? "experimental.vector.reduce." : "vector.reduce." | |||
There was a problem hiding this comment.
This could be declared outside the function (with a different name).
There was a problem hiding this comment.
Alternatively, I could replace this with
ff_base = string(Base.libllvm_version < v"12" ? "experimental.vector.reduce." : "vector.reduce.", $(QuoteNode(f)))For the negligible improvement in compilation time from not concatenating inside the @generated function body.
Please let me know which you prefer.
There was a problem hiding this comment.
I prefer code that is the easiest to read. Compile time differences will be negligible, and there will not be any run time difference. Since there is an existing, similar check outside the function, I thought it would be good to either have all version-dependent checks in the same place. Anything else I leave to you.
src/LLVM_intrinsics.jl
Outdated
| for (f, neutral) in [(:fadd, "0.0"), (:fmul, "1.0")] | ||
| f_red = Symbol("reduce_", f) | ||
| ff_base = Base.libllvm_version < v"12" ? "experimental.vector.reduce.$horz_reduction_version" : "vector.reduce.$horz_reduction_version" |
There was a problem hiding this comment.
This could be declared outside the function (with a different name), next to horz_reduction_version.
|
Is there a way to test with LLVM 12? |
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 93.28% 93.28%
=======================================
Files 5 5
Lines 700 700
=======================================
Hits 653 653
Misses 47 47
Continue to review full report at Codecov.
|
You can check out JuliaLang/julia#40774 which has pre-built artifacts for LLVM |
|
I tried it locally: Testing SIMD tests passed
julia> Base.libllvm_version
v"12.0.0"
julia> versioninfo()
Julia Version 1.7.0-DEV.1093
Commit 0942e35fbd* (2021-05-12 15:45 UTC)
Platform Info:
OS: Linux (x86_64-generic-linux)
CPU: Intel(R) Core(TM) i9-7900X CPU @ 3.30GHz
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-12.0.0 (ORCJIT, skylake-avx512)
Environment:
JULIA_NUM_THREADS = auto |
I haven't actually tested on LLVM 12.