feat(worker/monitor/pusher): creating pusher subcomponent #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriRDev
requested changes
Apr 23, 2024
lffg
approved these changes
Apr 23, 2024
| let metrics = metrics_report.get_metrics(); | ||
|
|
||
| let _ = client | ||
| .post("http://localhost:3000/worker/metrics") |
There was a problem hiding this comment.
Since we're going to abstract the client into the sender module later, this hard-coded string isn't a problem for now.
| sleep(args.metrics_report_interval).await; | ||
| let metrics = metrics_report.get_metrics(); | ||
|
|
||
| let _ = client |
There was a problem hiding this comment.
This code ignores the error. What if a network error occurs? How should we handle it? We may decide later on.
There was a problem hiding this comment.
I'm fine with leaving it as is for now. Filing an issue for a future proper handle might be an option.
There was a problem hiding this comment.
I agree with Gustavo, we should create a issue for this to handle it, but leave the priority as low as possible.
gustavodiasag
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.