Room EventData is map now #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3111 +/- ##
==========================================
- Coverage 79.22% 79.19% -0.03%
==========================================
Files 388 388
Lines 31858 31846 -12
==========================================
- Hits 25238 25220 -18
- Misses 6620 6626 +6
Continue to review full report at Codecov.
|
NelsonVides
reviewed
May 7, 2021
CHANGELOG.md
Outdated
Comment on lines
1
to
5
| - Use a map instead of a proplist in the `room_event_data` hook | ||
| for the event data information. | ||
| - `room_send_packet` hook removed. | ||
| Use `filter_room_packet` instead. | ||
|
|
There was a problem hiding this comment.
I don't think this is the place to put these things, they should go to the proper migration file
There was a problem hiding this comment.
I am just making less work for people, who need to write a changelog for the next release.
NelsonVides
approved these changes
May 10, 2021
NelsonVides
requested changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses "some tech debt".
Proposed changes include: