Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbons upgrade to 0.13.2 #3125

Merged
merged 13 commits into from
May 21, 2021
Merged

Carbons upgrade to 0.13.2 #3125

merged 13 commits into from
May 21, 2021

Conversation

NelsonVides
Copy link
Collaborator

Including appending the MAM stanza-id as required by the lastest mam xep, and moving the mam hooks order earlier in the priority line.

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #3125 (3a54add) into master (b48c3e9) will increase coverage by 0.14%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3125      +/-   ##
==========================================
+ Coverage   79.06%   79.21%   +0.14%     
==========================================
  Files         393      389       -4     
  Lines       32106    31974     -132     
==========================================
- Hits        25386    25328      -58     
+ Misses       6720     6646      -74     
Impacted Files Coverage Δ
src/ejabberd_c2s.erl 89.35% <66.66%> (ø)
src/mod_carboncopy.erl 88.73% <92.53%> (+2.68%) ⬆️
src/ejabberd_sm.erl 82.03% <100.00%> (-2.51%) ⬇️
src/event_pusher/mod_event_pusher_push.erl 94.68% <100.00%> (ø)
src/mam/mod_mam.erl 89.09% <100.00%> (+0.10%) ⬆️
src/mam/mod_mam_muc.erl 73.01% <100.00%> (ø)
src/ejabberd_local.erl 71.22% <0.00%> (-5.16%) ⬇️
src/mod_muc_iq.erl 65.00% <0.00%> (-4.57%) ⬇️
src/domain/mongoose_subdomain_core.erl 86.27% <0.00%> (-3.15%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 70.75% <0.00%> (-2.36%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4fb80...3a54add. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a few minor questions.

big_tests/tests/carboncopy_SUITE.erl Show resolved Hide resolved
src/mod_carboncopy.erl Show resolved Hide resolved
test/ejabberd_sm_SUITE.erl Outdated Show resolved Hide resolved
test/carboncopy_proper_tests_SUITE.erl Show resolved Hide resolved
test/carboncopy_proper_tests_SUITE.erl Outdated Show resolved Hide resolved
src/mod_carboncopy.erl Show resolved Hide resolved
@chrzaszcz chrzaszcz merged commit eefa5ed into master May 21, 2021
@chrzaszcz chrzaszcz deleted the carbons branch May 21, 2021 09:15
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants