-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbons upgrade to 0.13.2 #3125
Conversation
This way, the mam_id can be stored in the accumulator and reused by carbons, which is a requirement by MAM and Carbons XEPs. It could also be used by Inbox.
Codecov Report
@@ Coverage Diff @@
## master #3125 +/- ##
==========================================
+ Coverage 79.06% 79.21% +0.14%
==========================================
Files 393 389 -4
Lines 32106 31974 -132
==========================================
- Hits 25386 25328 -58
+ Misses 6720 6646 -74
Continue to review full report at Codecov.
|
Add, extend, and fix, carbon unit-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have a few minor questions.
Including appending the MAM stanza-id as required by the lastest mam xep, and moving the mam hooks order earlier in the priority line.