-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dummy auth delays configurable #3131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3131 +/- ##
==========================================
+ Coverage 79.46% 79.47% +0.01%
==========================================
Files 395 395
Lines 32168 32172 +4
==========================================
+ Hits 25563 25570 +7
+ Misses 6605 6602 -3
Continue to review full report at Codecov.
|
@@ -646,6 +647,17 @@ auth_rdbms() -> | |||
format = none | |||
}. | |||
|
|||
%% path: (host_config[].)auth.dummy | |||
auth_dummy() -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about to test it? e.g. we can set this configuration options for "test type" host_type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed so :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, now carboncopy for dynamic domains is pretty fast: https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3131/55777/pgsql_mnesia.23.0.3-1/big/ct_run.test@default-44683ef9-9b3c-4852-b093-e90d801f50e2.2021-05-27_09.27.12/big_tests.tests.carboncopy_SUITE.logs/run.2021-05-27_09.27.14/suite.log.html 😄
4d31afa
to
c239f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I like this change.
This makes the delays configurable, which by default are too long and that's something that can be noticed in CI.