Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dummy auth delays configurable #3131

Merged
merged 3 commits into from
May 27, 2021

Conversation

NelsonVides
Copy link
Collaborator

This makes the delays configurable, which by default are too long and that's something that can be noticed in CI.

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #3131 (c239f44) into master (5166ab3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3131      +/-   ##
==========================================
+ Coverage   79.46%   79.47%   +0.01%     
==========================================
  Files         395      395              
  Lines       32168    32172       +4     
==========================================
+ Hits        25563    25570       +7     
+ Misses       6605     6602       -3     
Impacted Files Coverage Δ
src/auth/ejabberd_auth_dummy.erl 68.18% <100.00%> (+5.02%) ⬆️
src/config/mongoose_config_spec.erl 98.48% <100.00%> (+<0.01%) ⬆️
src/pubsub/node_hometree.erl 77.77% <0.00%> (-5.56%) ⬇️
src/wpool/mongoose_wpool.erl 84.00% <0.00%> (-1.00%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 65.09% <0.00%> (-0.95%) ⬇️
src/ejabberd_sm.erl 84.17% <0.00%> (-0.34%) ⬇️
src/mam/mod_mam_utils.erl 89.56% <0.00%> (-0.34%) ⬇️
src/mod_muc_room.erl 77.45% <0.00%> (-0.06%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
src/ejabberd_c2s.erl 89.35% <0.00%> (+0.07%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5166ab3...c239f44. Read the comment docs.

@@ -646,6 +647,17 @@ auth_rdbms() ->
format = none
}.

%% path: (host_config[].)auth.dummy
auth_dummy() ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about to test it? e.g. we can set this configuration options for "test type" host_type.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed so :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NelsonVides NelsonVides force-pushed the configurable_dummy_auth_delays branch from 4d31afa to c239f44 Compare May 27, 2021 09:07
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like this change.

@DenysGonchar DenysGonchar merged commit e55fa8e into master May 27, 2021
@DenysGonchar DenysGonchar deleted the configurable_dummy_auth_delays branch May 27, 2021 09:59
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants