-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gen_fsm_compat from big_tests #3218
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
- Coverage 80.28% 80.25% -0.04%
==========================================
Files 397 397
Lines 32474 32474
==========================================
- Hits 26072 26062 -10
- Misses 6402 6412 +10
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / 0d29b5b internal_mnesia_24 / internal_mnesia / 0d29b5b dynamic_domains_24 / pgsql_mnesia / 0d29b5b dynamic_domains_23 / pgsql_mnesia / 0d29b5b small_tests_22 / small_tests / 0d29b5b small_tests_23 / small_tests / 0d29b5b ldap_mnesia_24 / ldap_mnesia / 0d29b5b ldap_mnesia_23 / ldap_mnesia / 0d29b5b ldap_mnesia_22 / ldap_mnesia / 0d29b5b pgsql_mnesia_23 / pgsql_mnesia / 0d29b5b elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0d29b5b mysql_redis_24 / mysql_redis / 0d29b5b pgsql_mnesia_22 / pgsql_mnesia / 0d29b5b mssql_mnesia_24 / odbc_mssql_mnesia / 0d29b5b riak_mnesia_24 / riak_mnesia / 0d29b5b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[{_,_,Pid}|_] -> | ||
%% @TODO related to gen_fsm_compat: after migration to gen_statem | ||
%% should be replaced to - gen_statem:call(Pid, destroy). | ||
Pid ! {'$gen_all_state_event', destroy}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple, though code gets a bit uglier in the meantime, this is now a way less self-explaining line of code than before. Looking forward for the migration to gen_statem
!
No description provided.