Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call remove_domain hook #3237

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Call remove_domain hook #3237

merged 2 commits into from
Aug 30, 2021

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Aug 30, 2021

This PR addresses "[JIRA] (MIM-1453) Start calling remove_domain hook"

Proposed changes include:

  • Add a call
  • Add a test
  • Also yeah, lserver_to_host_type is crashes now if host_type is not found.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 30, 2021

small_tests_24 / small_tests / d409f88
Reports root / small


internal_mnesia_24 / internal_mnesia / d409f88
Reports root/ big
OK: 1588 / Failed: 0 / User-skipped: 290 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / d409f88
Reports root/ big
OK: 1690 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


small_tests_22 / small_tests / d409f88
Reports root / small


dynamic_domains_23 / pgsql_mnesia / d409f88
Reports root/ big
OK: 1690 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


small_tests_23 / small_tests / d409f88
Reports root / small


ldap_mnesia_24 / ldap_mnesia / d409f88
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


ldap_mnesia_22 / ldap_mnesia / d409f88
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / d409f88
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / d409f88
Reports root/ big
OK: 1515 / Failed: 0 / User-skipped: 363 / Auto-skipped: 0


pgsql_mnesia_22 / pgsql_mnesia / d409f88
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d409f88
Reports root/ big
OK: 1891 / Failed: 0 / User-skipped: 286 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / d409f88
Reports root/ big
OK: 3073 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / d409f88
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / d409f88
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / d409f88
Reports root/ big
OK: 1738 / Failed: 0 / User-skipped: 289 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #3237 (d409f88) into master (3e61c13) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
- Coverage   80.35%   80.34%   -0.01%     
==========================================
  Files         398      398              
  Lines       32526    32534       +8     
==========================================
+ Hits        26135    26140       +5     
- Misses       6391     6394       +3     
Impacted Files Coverage Δ
src/mam/mod_mam.erl 89.16% <83.33%> (+0.18%) ⬆️
src/domain/mongoose_domain_api.erl 100.00% <100.00%> (ø)
src/mod_roster_rdbms.erl 88.61% <0.00%> (-7.32%) ⬇️
src/mod_last_rdbms.erl 91.66% <0.00%> (-4.17%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/domain/mongoose_domain_loader.erl 75.47% <0.00%> (-1.89%) ⬇️
src/mod_last.erl 86.36% <0.00%> (-1.52%) ⬇️
src/mod_bosh_socket.erl 77.95% <0.00%> (-0.94%) ⬇️
src/rdbms/mongoose_rdbms.erl 60.88% <0.00%> (-0.81%) ⬇️
src/offline/mod_offline.erl 77.90% <0.00%> (-0.56%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e61c13...d409f88. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this!

@chrzaszcz chrzaszcz merged commit 6cf4127 into master Aug 30, 2021
@chrzaszcz chrzaszcz deleted the mu-call-remove-domain-hook branch August 30, 2021 12:14
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants