-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify big test config templating for modules #3238
Conversation
small_tests_24 / small_tests / 914ef28 internal_mnesia_24 / internal_mnesia / 914ef28 small_tests_22 / small_tests / 914ef28 dynamic_domains_24 / pgsql_mnesia / 914ef28 dynamic_domains_23 / pgsql_mnesia / 914ef28 small_tests_23 / small_tests / 914ef28 ldap_mnesia_24 / ldap_mnesia / 914ef28 ldap_mnesia_22 / ldap_mnesia / 914ef28 mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,435},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> => <<"muc_publish@muc.localhost">>,
<<"message">> => <<>>,
<<"to_user_id">> =>
<<"alice_unnamed_11.330969@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-0-',3,
[{file,
"/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,435}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} ldap_mnesia_23 / ldap_mnesia / 914ef28 mssql_mnesia_24 / odbc_mssql_mnesia / 914ef28 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_16.633933@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_16.633933@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"+lqMFazpbCtO+J5zauoPAw==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/app/big_tests/tests/pep_SUITE.erl"},
{line,382}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} pgsql_mnesia_23 / pgsql_mnesia / 914ef28 mysql_redis_24 / mysql_redis / 914ef28 service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>],
[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>,<<"example4.com">>]}}} elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 914ef28 pgsql_mnesia_24 / pgsql_mnesia / 914ef28 pgsql_mnesia_22 / pgsql_mnesia / 914ef28 riak_mnesia_24 / riak_mnesia / 914ef28 |
Codecov Report
@@ Coverage Diff @@
## master #3238 +/- ##
=======================================
Coverage 80.35% 80.35%
=======================================
Files 398 398
Lines 32526 32526
=======================================
Hits 26135 26135
Misses 6391 6391
Continue to review full report at Codecov.
|
- For static domains, there are two distinct host type - For dynamic domains, there is only one host type
small_tests_24 / small_tests / 50d8df9 small_tests_23 / small_tests / 50d8df9 dynamic_domains_23 / pgsql_mnesia / 50d8df9 ldap_mnesia_23 / ldap_mnesia / 50d8df9 internal_mnesia_24 / internal_mnesia / 50d8df9 pgsql_mnesia_23 / pgsql_mnesia / 50d8df9 dynamic_domains_23 / pgsql_mnesia / 50d8df9 small_tests_22 / small_tests / 50d8df9 ldap_mnesia_22 / ldap_mnesia / 50d8df9 small_tests_23 / small_tests / 50d8df9 ldap_mnesia_23 / ldap_mnesia / 50d8df9 dynamic_domains_23 / pgsql_mnesia / 50d8df9 small_tests_23 / small_tests / 50d8df9 ldap_mnesia_23 / ldap_mnesia / 50d8df9 ldap_mnesia_22 / ldap_mnesia / 50d8df9 small_tests_22 / small_tests / 50d8df9 pgsql_mnesia_22 / pgsql_mnesia / 50d8df9 |
small_tests_24 / small_tests / b2dc276 internal_mnesia_24 / internal_mnesia / b2dc276 dynamic_domains_24 / pgsql_mnesia / b2dc276 small_tests_22 / small_tests / b2dc276 dynamic_domains_23 / pgsql_mnesia / b2dc276 small_tests_23 / small_tests / b2dc276 ldap_mnesia_24 / ldap_mnesia / b2dc276 ldap_mnesia_23 / ldap_mnesia / b2dc276 ldap_mnesia_22 / ldap_mnesia / b2dc276 pgsql_mnesia_24 / pgsql_mnesia / b2dc276 pgsql_mnesia_22 / pgsql_mnesia / b2dc276 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / b2dc276 pgsql_mnesia_23 / pgsql_mnesia / b2dc276 mssql_mnesia_24 / odbc_mssql_mnesia / b2dc276 mysql_redis_24 / mysql_redis / b2dc276 amp_big_SUITE:basic:notify_deliver_to_stranger_test{error,
{{assertion_failed,assert,is_presence,
{xmlel,<<"stream:error">>,[],
[{xmlel,<<"conflict">>,
[{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[]},
{xmlel,<<"text">>,
[{<<"xml:lang">>,<<"en">>},
{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[{xmlcdata,<<"Replaced by new connection">>}]}]},
"<stream:error><conflict xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Replaced by new connection</text></stream:error>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-drop_presences/2-lc$^0/1-0-',1,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,drop_presences,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,135}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_story,start_ready_clients,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,128}]},
... mam_SUITE:rdbms_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}} riak_mnesia_24 / riak_mnesia / b2dc276 |
small_tests_24 / small_tests / 562798e internal_mnesia_24 / internal_mnesia / 562798e small_tests_22 / small_tests / 562798e dynamic_domains_24 / pgsql_mnesia / 562798e dynamic_domains_23 / pgsql_mnesia / 562798e small_tests_23 / small_tests / 562798e ldap_mnesia_22 / ldap_mnesia / 562798e ldap_mnesia_24 / ldap_mnesia / 562798e ldap_mnesia_23 / ldap_mnesia / 562798e pgsql_mnesia_24 / pgsql_mnesia / 562798e pgsql_mnesia_22 / pgsql_mnesia / 562798e elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 562798e mssql_mnesia_24 / odbc_mssql_mnesia / 562798e pgsql_mnesia_23 / pgsql_mnesia / 562798e mysql_redis_24 / mysql_redis / 562798e riak_mnesia_24 / riak_mnesia / 562798e |
Improve the consistency of the module config templates used for tests.
Use
test.config
options for static and dynamic domains and do not repeat the same configuration in test suites.This applies to two modules recently converted to use dynamic domains:
mod_private
andmod_vcard
.