Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbox quick improvements #3359

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Inbox quick improvements #3359

merged 2 commits into from
Oct 25, 2021

Conversation

NelsonVides
Copy link
Collaborator

Just quick code pattern fixes, plus saving a potentially hidden bug when comparing jids.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 25, 2021

small_tests_24 / small_tests / 5c88861
Reports root / small


internal_mnesia_24 / internal_mnesia / 5c88861
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / 5c88861
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5c88861
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 5c88861
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 5c88861
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 5c88861
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 5c88861
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 5c88861
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 5c88861
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 5c88861
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 5c88861
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 5c88861
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 5c88861
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 5c88861
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #3359 (5c88861) into master (e09d453) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3359      +/-   ##
==========================================
- Coverage   80.66%   80.63%   -0.03%     
==========================================
  Files         397      397              
  Lines       32441    32440       -1     
==========================================
- Hits        26168    26159       -9     
- Misses       6273     6281       +8     
Impacted Files Coverage Δ
src/inbox/mod_inbox_muclight.erl 100.00% <100.00%> (ø)
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/event_pusher/mod_event_pusher_sns.erl 84.21% <0.00%> (-5.27%) ⬇️
src/mod_bosh.erl 91.83% <0.00%> (-2.05%) ⬇️
src/mam/mod_mam_muc_rdbms_arch.erl 94.94% <0.00%> (-2.03%) ⬇️
src/logger/mongoose_json_formatter.erl 84.00% <0.00%> (-2.00%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 85.08% <0.00%> (-1.76%) ⬇️
src/mod_bosh_socket.erl 77.63% <0.00%> (-1.25%) ⬇️
src/inbox/mod_inbox_rdbms.erl 92.50% <0.00%> (-0.63%) ⬇️
src/ejabberd_c2s.erl 89.15% <0.00%> (-0.08%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09d453...5c88861. Read the comment docs.

@vkatsuba vkatsuba merged commit 4109562 into master Oct 25, 2021
@vkatsuba vkatsuba deleted the inbox_quick_improvements branch October 25, 2021 08:11
@Premwoik Premwoik modified the milestone: 5.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants