Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rest_client_SUITE:muc:messages_can_be_paginated_in_room #3363

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Fix rest_client_SUITE:muc:messages_can_be_paginated_in_room #3363

merged 1 commit into from
Oct 26, 2021

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Oct 25, 2021 •
edited
Loading

This PR addresses failing rest_client_SUITE:muc:messages_can_be_paginated_in_room testcase

Proposed changes include:

  • Add day_offset and user_num into message body for debugging
  • Wait for messages to be in the archive in rest_helper:fill_room_archive
  • Ensure we generate messages with unique ids in rest_helper:fill_room_archive

#3360 with fail infos

@arcusfelis
Fix rest_client_SUITE:muc:messages_can_be_paginated_in_room
7b907f9 
Add day_offset and user_num into message body for debugging
Wait for messages to be in the archive in rest_helper:fill_room_archive
Ensure we generate messages with unique ids in rest_helper:fill_room_archive
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 25, 2021 •
edited
Loading

small_tests_24 / small_tests / 7b907f9
Reports root / small

internal_mnesia_24 / internal_mnesia / 7b907f9
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / 7b907f9
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7b907f9
Reports root/ big
OK: 2700 / Failed: 1 / User-skipped: 184 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global 
{error,{{badmatch,{"5\n",0}},
    [{mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
                [{file,"/home/circleci/app/big_tests/tests/mongooseimctl_SUITE.erl"},
                 {line,1056}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / 7b907f9
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 7b907f9
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 7b907f9
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 7b907f9
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7b907f9
Reports root/ big
OK: 2701 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

inbox_SUITE:one_to_one:reset_unread_counter_and_show_only_unread 
{error,{badarg,[{erlang,binary_to_integer,
            [undefined],
            [{error_info,#{module => erl_erts_errors}}]},
        {inbox_helper,get_result_el,2,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,236}]},
        {inbox_helper,'-check_result/2-fun-0-',3,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,241}]},
        {maps,filter_1,2,[{file,"maps.erl"},{line,318}]},
        {maps,filter,2,[{file,"maps.erl"},{line,309}]},
        {inbox_helper,get_inbox,3,
                [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
                 {line,222}]},
        {escalus_story,story,4,
                 [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
                {line,72}]},
        {test_server,ts_tc,3,
               [{file,"test_server.erl"},{line,1783}]}]}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / 7b907f9
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7b907f9
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 7b907f9
Reports root/ big
OK: 3070 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join 
{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>],
              [<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>,<<"example4.com">>]}}}

Report log

mysql_redis_24 / mysql_redis / 7b907f9
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 7b907f9
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 7b907f9
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7b907f9
Reports root/ big
OK: 2700 / Failed: 1 / User-skipped: 184 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global 
{error,{{badmatch,{"5\n",0}},
    [{mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
                [{file,"/home/circleci/app/big_tests/tests/mongooseimctl_SUITE.erl"},
                 {line,1056}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7b907f9
Reports root/ big
OK: 2700 / Failed: 2 / User-skipped: 184 / Auto-skipped: 0

amp_big_SUITE:offline:offline_failure:notify_deliver_to_offline_user_recipient_privacy_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_notify_deliver_to_offline_user_recipient_privacy_test_21.864952_notify_deliver_to_offline_user_recipient_privacy_test_23.657606">>,
            <<"domain.example.com">>,<<"makrolika">>],
             3000,ejabberd],
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:notify_deliver_to_offline_user_recipient_privacy_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_notify_deliver_to_offline_user_recipient_privacy_test_21.872269_notify_deliver_to_offline_user_recipient_privacy_test_23.685043">>,
            <<"domain.example.com">>,<<"makrolika">>],
             3000,ejabberd],
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_23 / pgsql_mnesia / 7b907f9
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7b907f9
Reports root/ big
OK: 2699 / Failed: 3 / User-skipped: 184 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join 
{error,{test_case_failed,{[<<"example1.com">>],
              [<<"example1.com">>,<<"example2.com">>]}}}

Report log

service_domain_db_SUITE:db:rest_with_auth:rest_delete_domain_cleans_data_from_mam 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_rest_delete_domain_cleans_data_from_mam_49.615049@example.org/res1">>,
          escalus_tcp,<0.28850.1>,
          [{event_manager,<0.28844.1>},
           {server,<<"example.org">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_49.615049">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.28844.1>},
            {server,<<"example.org">>},
            {username,
              <<"bob_rest_delete_domain_cleans_data_from_mam_49.615049">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_49.615049">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {port,5232},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_49.615049">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {password,<<"makota3">>},
           {port,5232},
           {stream_id,<<"32808117e908f281">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {service_domain_db_SUITE,
       '-rest_delete_domain_cleans_data_from_mam/1-fun-0-',5...

Report log

service_domain_db_SUITE:db:rest_without_auth:rest_delete_domain_cleans_data_from_mam 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_rest_delete_domain_cleans_data_from_mam_57.628018@example.org/res1">>,
          escalus_tcp,<0.29493.1>,
          [{event_manager,<0.29487.1>},
           {server,<<"example.org">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_57.628018">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.29487.1>},
            {server,<<"example.org">>},
            {username,
              <<"bob_rest_delete_domain_cleans_data_from_mam_57.628018">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_57.628018">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {port,5232},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_57.628018">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {password,<<"makota3">>},
           {port,5232},
           {stream_id,<<"05404e50960081f6">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {service_domain_db_SUITE,
       '-rest_delete_domain_cleans_data_from_mam/1-fun-0-',5...

Report log

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7b907f9
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7b907f9
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 25, 2021 •
edited
Loading

Codecov Report

Merging #3363 (7b907f9) into master (e09d453) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3363      +/-   ##
==========================================
- Coverage   80.66%   80.65%   -0.01%     
==========================================
  Files         397      397              
  Lines       32441    32441              
==========================================
- Hits        26168    26165       -3     
- Misses       6273     6276       +3
Impacted Files Coverage Δ
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mod_bosh.erl 91.83% <0.00%> (-2.05%) ⬇️
src/mam/mod_mam_muc_rdbms_arch.erl 94.94% <0.00%> (-2.03%) ⬇️
src/logger/mongoose_json_formatter.erl 84.00% <0.00%> (-2.00%) ⬇️
src/domain/mongoose_domain_loader.erl 77.35% <0.00%> (-1.89%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 85.08% <0.00%> (-1.76%) ⬇️
src/mod_bosh_socket.erl 77.63% <0.00%> (-1.25%) ⬇️
src/mod_roster_rdbms.erl 95.38% <0.00%> (-0.77%) ⬇️
src/metrics/mongoose_metrics.erl 95.45% <0.00%> (-0.65%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09d453...7b907f9. Read the comment docs.

@vkatsuba vkatsuba merged commit 9713afd into master Oct 26, 2021
@vkatsuba vkatsuba deleted the mu-fix-rest-client-mam-muc-testcase branch October 26, 2021 07:05
@Premwoik Premwoik modified the milestone: 5.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkatsuba vkatsuba vkatsuba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@arcusfelis @mongoose-im @vkatsuba @Premwoik