Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dynamically compiled modules from mod_keystore #3375

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Removing dynamically compiled modules from mod_keystore #3375

merged 3 commits into from
Nov 3, 2021

Conversation

JanuszJakubiec
Copy link
Contributor

Removing dynamically compiled modules froem mod_keystore

@JanuszJakubiec JanuszJakubiec changed the title Removing dynamically compiled modules froem mod_keystore Removing dynamically compiled modules from mod_keystore Oct 28, 2021
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 28, 2021 •
edited
Loading

small_tests_24 / small_tests / 5c6a63e
Reports root / small

internal_mnesia_24 / internal_mnesia / 5c6a63e
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / 5c6a63e
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5c6a63e
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 5c6a63e
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 5c6a63e
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 5c6a63e
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 5c6a63e
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 5c6a63e
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 5c6a63e
Reports root/ big
OK: 3089 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

jingle_SUITE:all:jingle_session_is_established_when_calling_a_number 
{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"+488790@numbers.localhost">>},
        {<<"to">>,
         <<"alice_jingle_session_is_established_when_calling_a_number_97.492042@localhost/res1">>},
        {<<"id">>,<<"6b5051d9-5686-4e0f-89c3-1861eee80bab">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-info">>},
           {<<"sid">>,<<"e1ba04c3-c863-49c0-8920-29dbba3f7304">>}],
          [{xmlel,<<"ringing">>,
             [{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
             []}]}]},
     "<iq from='+488790@numbers.localhost' to='alice_jingle_session_is_established_when_calling_a_number_97.492042@localhost/res1' id='6b5051d9-5686-4e0f-89c3-1861eee80bab' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='e1ba04c3-c863-49c0-8920-29dbba3f7304'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {line,395}]},
    {jingle_SUITE,
      '-jingle_session_is_established_when_calling_a_number/1-fun-0-',1,
      [{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
       {lin...

Report log

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 5c6a63e
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 5c6a63e
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 5c6a63e
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 5c6a63e
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 5c6a63e
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 28, 2021 •
edited
Loading

Codecov Report

Merging #3375 (4ce1ea7) into without-dynamic-backend-modules (e29d70a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           without-dynamic-backend-modules    #3375      +/-   ##
===================================================================
+ Coverage                            80.85%   80.87%   +0.02%     
===================================================================
  Files                                  413      414       +1     
  Lines                                32639    32645       +6     
===================================================================
+ Hits                                 26389    26403      +14     
+ Misses                                6250     6242       -8
Impacted Files Coverage Δ
src/mod_keystore_mnesia.erl 78.57% <ø> (ø)
src/mod_keystore.erl 89.09% <100.00%> (-0.20%) ⬇️
src/mod_keystore_backend.erl 100.00% <100.00%> (ø)
src/mongoose_hooks.erl 94.02% <100.00%> (ø)
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
src/domain/mongoose_domain_loader.erl 77.35% <0.00%> (-1.89%) ⬇️
src/global_distrib/mod_global_distrib_receiver.erl 80.00% <0.00%> (-1.12%) ⬇️
src/mod_muc.erl 73.76% <0.00%> (-0.23%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
src/mod_bosh_socket.erl 78.88% <0.00%> (+1.24%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c2bca9...4ce1ea7. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 29, 2021 •
edited
Loading

small_tests_24 / small_tests / ba5c343
Reports root / small

internal_mnesia_24 / internal_mnesia / ba5c343
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / ba5c343
Reports root / small

ldap_mnesia_24 / ldap_mnesia / ba5c343
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ba5c343
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / ba5c343
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / ba5c343
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / ba5c343
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / ba5c343
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ba5c343
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / ba5c343
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / ba5c343
Reports root/ big
OK: 3078 / Failed: 2 / User-skipped: 228 / Auto-skipped: 0

rest_client_SUITE:muc:messages_can_be_paginated_in_room 
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"625f0449">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"1635-504010-525021@muclight.localhost">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"e243258a">>}]}]},
     "<message to='1635-504010-525021@muclight.localhost' type='chat'><body>e243258a</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join 
{error,{test_case_failed,{[<<"example1.com">>],
              [<<"example1.com">>,<<"example2.com">>]}}}

Report log

mssql_mnesia_24 / odbc_mssql_mnesia / ba5c343
Reports root/ big
OK: 3096 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

rest_client_SUITE:muc:messages_can_be_paginated_in_room 
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"0c05778c">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"1635-504014-37420@muclight.localhost">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"37ab387a">>}]}]},
     "<message to='1635-504014-37420@muclight.localhost' type='chat'><body>37ab387a</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_23 / pgsql_mnesia / ba5c343
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / ba5c343
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / ba5c343
Reports root/ big
OK: 3085 / Failed: 2 / User-skipped: 228 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_never 
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log

rest_client_SUITE:muc:messages_can_be_paginated_in_room 
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"13f75ad4">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"1635-855238-227938@muclight.localhost">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"617c81e1">>}]}]},
     "<message to='1635-855238-227938@muclight.localhost' type='chat'><body>617c81e1</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 3, 2021 •
edited
Loading

small_tests_24 / small_tests / 4ce1ea7
Reports root / small

internal_mnesia_24 / internal_mnesia / 4ce1ea7
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / 4ce1ea7
Reports root / small

dynamic_domains_mysql_redis_24 / mysql_redis / 4ce1ea7
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 4ce1ea7
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 4ce1ea7
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4ce1ea7
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 4ce1ea7
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 4ce1ea7
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 4ce1ea7
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 4ce1ea7
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 4ce1ea7
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 4ce1ea7
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 4ce1ea7
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 4ce1ea7
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

gustawlippa
gustawlippa approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@gustawlippa gustawlippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks OK

@gustawlippa gustawlippa merged commit 9ca4366 into without-dynamic-backend-modules Nov 3, 2021
@gustawlippa gustawlippa deleted the keystore-remove-dynamic-modules branch November 3, 2021 09:30
@Premwoik Premwoik modified the milestone: 5.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustawlippa gustawlippa gustawlippa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JanuszJakubiec @mongoose-im @gustawlippa @Premwoik