Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded xref ignore #3418

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Unneeded xref ignore #3418

merged 1 commit into from
Nov 26, 2021

Conversation

NelsonVides
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #3418 (6280d9b) into master (bd34cea) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
+ Coverage   79.10%   79.13%   +0.02%     
==========================================
  Files         414      414              
  Lines       32298    32298              
==========================================
+ Hits        25549    25558       +9     
+ Misses       6749     6740       -9     
Impacted Files Coverage Δ
src/muc_light/mod_muc_light_room.erl 93.82% <ø> (ø)
..._distrib/mod_global_distrib_outgoing_conns_sup.erl 80.00% <0.00%> (-8.00%) ⬇️
src/domain/mongoose_domain_sql.erl 82.85% <0.00%> (-2.86%) ⬇️
src/mod_roster_rdbms.erl 95.38% <0.00%> (-0.77%) ⬇️
src/mod_muc_log.erl 78.11% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.19% <0.00%> (+0.05%) ⬆️
src/ejabberd_c2s.erl 89.19% <0.00%> (+0.29%) ⬆️
src/ejabberd_sm.erl 84.59% <0.00%> (+0.32%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 77.40% <0.00%> (+0.56%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 77.35% <0.00%> (+1.88%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd34cea...6280d9b. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 26, 2021

small_tests_24 / small_tests / 6280d9b
Reports root / small


small_tests_23 / small_tests / 6280d9b
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6280d9b
Reports root/ big
OK: 2722 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 6280d9b
Reports root/ big
OK: 2722 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 6280d9b
Reports root/ big
OK: 2705 / Failed: 0 / User-skipped: 203 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 6280d9b
Reports root/ big
OK: 2722 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 6280d9b
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 382 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 6280d9b
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 382 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 6280d9b
Reports root/ big
OK: 1587 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 6280d9b
Reports root/ big
OK: 3109 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 6280d9b
Reports root/ big
OK: 3109 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 6280d9b
Reports root/ big
OK: 3104 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 6280d9b
Reports root/ big
OK: 3109 / Failed: 0 / User-skipped: 195 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6280d9b
Reports root/ big
OK: 1880 / Failed: 0 / User-skipped: 309 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 6280d9b
Reports root/ big
OK: 1725 / Failed: 1 / User-skipped: 310 / Auto-skipped: 0

amp_big_SUITE:basic:drop_deliver_to_offline_user_test
{error,
  {test_case_failed,
    {has_stanzas_but_shouldnt,
      {client,
        <<"alicE_drop_deliver_to_offline_user_test_48.349067@localhost/res1">>,
        escalus_tcp,<0.3048.0>,
        [{event_manager,<0.2921.0>},
         {server,<<"localhost">>},
         {username,
           <<"alicE_drop_deliver_to_offline_user_test_48.349067">>},
         {resource,<<"res1">>}],
        [{event_client,
           [{event_manager,<0.2921.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_drop_deliver_to_offline_user_test_48.349067">>},
            {resource,<<"res1">>}]},
         {resource,<<"res1">>},
         {username,
           <<"alicE_drop_deliver_to_offline_user_test_48.349067">>},
         {server,<<"localhost">>},
         {host,<<"localhost">>},
         {port,5222},
         {auth,{escalus_auth,auth_plain}},
         {wspath,undefined},
         {username,
           <<"alicE_drop_deliver_to_offline_user_test_48.349067">>},
         {server,<<"localhost">>},
         {password,<<"matygrysa">>},
         {stream_id,<<"fb2b2e2678a00d58">>}]},
      [{xmlel,<<"stream:error">>,[],
         [{xmlel,<<"conflict">>,
            [{<<"xmlns">>,
            <<"urn:ietf:params:xml:ns:xmpp-streams">>}],
            []},
          {xmlel,<<"text">>,
            [{<<"xml:lang">>,<<"en">>},
             {<<"xmlns">>,
            <<"urn:ietf:params:xml:ns:xmpp-streams">>}],
            [{xmlcdata,<<"Replaced by new connection">>}]}]},
       {...

Report log

Copy link
Contributor

@gustawlippa gustawlippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@gustawlippa gustawlippa merged commit c3865ff into master Nov 26, 2021
@gustawlippa gustawlippa deleted the quick_xref_unneeded_ignore branch November 26, 2021 15:01
@Premwoik Premwoik modified the milestone: 5.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants