-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automatic certs rebuild #3447
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3447 +/- ##
==========================================
- Coverage 80.85% 80.82% -0.04%
==========================================
Files 415 415
Lines 32312 32312
==========================================
- Hits 26125 26115 -10
- Misses 6187 6197 +10
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / ddb0a04 small_tests_23 / small_tests / ddb0a04 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ddb0a04 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / ddb0a04 dynamic_domains_mysql_redis_24 / mysql_redis / ddb0a04 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / ddb0a04 ldap_mnesia_23 / ldap_mnesia / ddb0a04 ldap_mnesia_24 / ldap_mnesia / ddb0a04 internal_mnesia_24 / internal_mnesia / ddb0a04 pgsql_mnesia_23 / pgsql_mnesia / ddb0a04 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ddb0a04 pgsql_mnesia_24 / pgsql_mnesia / ddb0a04 mssql_mnesia_24 / odbc_mssql_mnesia / ddb0a04 mysql_redis_24 / mysql_redis / ddb0a04 riak_mnesia_24 / riak_mnesia / ddb0a04 |
@@ -62,7 +62,7 @@ $(DEVNODES): certs configure.out rel/vars-toml.config | |||
DEVNODE=true $(RUN) $(REBAR) as $@ release) | |||
|
|||
maybe_clean_certs: | |||
if [ "$$SKIP_CERT_BUILD" = 1 ]; then \ | |||
if [ "$$SKIP_CERT_BUILD" != 1 ]; then \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea
Please get my certificates to rebuild automatically when they expire, please