Put mod_inbox in a map with defaults

[NelsonVides]

Wanted to come back to the topic of async workers for inbox but it would be good to have this one already, less conflicts later 🙂

[codecov]

Codecov Report

Merging #3547 (077fbe2) into master (6ca2443) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 077fbe2 differs from pull request most recent head 6469901. Consider uploading reports for the commit 6469901 to get more accurate results

@@           Coverage Diff           @@
##           master    #3547   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files         420      419    -1     
  Lines       32296    32287    -9     
=======================================
- Hits        26187    26180    -7     
+ Misses       6109     6107    -2     

Impacted Files	Coverage Δ
src/inbox/mod_inbox_backend.erl	100.00% <ø> (ø)
src/inbox/mod_inbox_entries.erl	95.31% <ø> (ø)
src/inbox/mod_inbox.erl	88.04% <100.00%> (+0.02%)	⬆️
src/inbox/mod_inbox_utils.erl	98.48% <100.00%> (ø)
src/system_metrics/mongoose_module_metrics.erl	83.33% <0.00%> (-16.67%)	⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl	71.69% <0.00%> (-1.89%)	⬇️
src/mod_bosh.erl	94.36% <0.00%> (-1.26%)	⬇️
src/mam/mod_mam_rdbms_arch_async.erl	96.62% <0.00%> (-1.13%)	⬇️
src/mod_auth_token.erl	81.50% <0.00%> (-0.57%)	⬇️
src/mod_roster.erl	78.52% <0.00%> (-0.24%)	⬇️
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca2443...6469901. Read the comment docs.

[chrzaszcz]

Looks good in general, I have a few minor comments. A mistake in tests allowed me to find a small bug in test helpers.

[mongoose-im]

small_tests_24 / small_tests / 6469901
Reports root / small

---

small_tests_23 / small_tests / 6469901
Reports root / small

---

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 6469901
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6469901
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 6469901
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0

---

ldap_mnesia_24 / ldap_mnesia / 6469901
Reports root/ big
OK: 1510 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_24 / mysql_redis / 6469901
Reports root/ big
OK: 2703 / Failed: 1 / User-skipped: 256 / Auto-skipped: 0

rest_SUITE:admin:session_can_be_kicked

{error,{test_case_failed,[70,97,105,108,58,32,
              [60,60,
               "\"alice_session_can_be_kicked_1744@domain.example.com/res1\"",
               62,62],
              32,105,110,32,
              [91,
               [[60,60,
               "\"alice_session_can_be_kicked_1744@domain.example.com/res1\"",
               62,62],
              44,10,
              [32,
               [[[32,["  ",32,32],"  ",32,32],
                 32,
                 ["  ",32,32],
                 "  ",32,32],
                [32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [[32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [32,["  ",32,32],"  ",32,32],
               32,
               ["  ",32,32],
               "  ",32,32],
              [60,60,
               "\"alice_messages_error_handling_1745@domain.example.com/res1\"",
               62,62],
              44,10,
              [32,
               [[[32,["  ",32,32],"  ",32,32],
                 32,
                 ["  ",32,32],
                 "  ",32,32],
                [32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [[32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [32,["  ",32,32],"  ",32,32],
               32,
      ...

Report log

---

ldap_mnesia_23 / ldap_mnesia / 6469901
Reports root/ big
OK: 1510 / Failed: 0 / User-skipped: 390 / Auto-skipped: 0

---

internal_mnesia_24 / internal_mnesia / 6469901
Reports root/ big
OK: 1551 / Failed: 0 / User-skipped: 349 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / 6469901
Reports root/ big
OK: 3095 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0

---

mysql_redis_24 / mysql_redis / 6469901
Reports root/ big
OK: 3090 / Failed: 0 / User-skipped: 253 / Auto-skipped: 0

---

mssql_mnesia_24 / odbc_mssql_mnesia / 6469901
Reports root/ big
OK: 3095 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0

---

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6469901
Reports root/ big
OK: 1844 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

---

riak_mnesia_24 / riak_mnesia / 6469901
Reports root/ big
OK: 1690 / Failed: 0 / User-skipped: 364 / Auto-skipped: 0

---

pgsql_mnesia_23 / pgsql_mnesia / 6469901
Reports root/ big
OK: 3095 / Failed: 0 / User-skipped: 248 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_24 / mysql_redis / 6469901
Reports root/ big
OK: 2704 / Failed: 0 / User-skipped: 256 / Auto-skipped: 0

[chrzaszcz]

Looks good!