-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mongoose_backend in mod_global_distrib_mapping #3582
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
It is global because: - It has to be started globally - There is only one backend: redis
Simplify function calls that always returned {ok, Val}.
1e2be66
to
3301486
Compare
This comment was marked as outdated.
This comment was marked as outdated.
small_tests_24 / small_tests / b00733a small_tests_23 / small_tests / b00733a dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b00733a dynamic_domains_mysql_redis_24 / mysql_redis / b00733a dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / b00733a dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / b00733a ldap_mnesia_24 / ldap_mnesia / b00733a ldap_mnesia_23 / ldap_mnesia / b00733a internal_mnesia_24 / internal_mnesia / b00733a elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / b00733a pgsql_mnesia_24 / pgsql_mnesia / b00733a pgsql_mnesia_23 / pgsql_mnesia / b00733a mysql_redis_24 / mysql_redis / b00733a mssql_mnesia_24 / odbc_mssql_mnesia / b00733a riak_mnesia_24 / riak_mnesia / b00733a |
Codecov Report
@@ Coverage Diff @@
## master #3582 +/- ##
==========================================
+ Coverage 79.26% 80.82% +1.56%
==========================================
Files 424 425 +1
Lines 32274 32282 +8
==========================================
+ Hits 25581 26092 +511
+ Misses 6693 6190 -503
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! One more to go...
Get rid of the dynamically compiled module.
Also: simplify functions that always returned
{ok, Val}
.