Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mongoose_backend in mod_global_distrib_mapping #3582

Merged
merged 4 commits into from
Mar 10, 2022

Conversation

chrzaszcz
Copy link
Member

Get rid of the dynamically compiled module.

Also: simplify functions that always returned {ok, Val}.

@mongoose-im

This comment was marked as outdated.

It is global because:
- It has to be started globally
- There is only one backend: redis
Simplify function calls that always returned {ok, Val}.
@chrzaszcz chrzaszcz force-pushed the mod_global_distrib_mapping-backend branch from 1e2be66 to 3301486 Compare March 9, 2022 15:04
@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 9, 2022

small_tests_24 / small_tests / b00733a
Reports root / small


small_tests_23 / small_tests / b00733a
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b00733a
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / b00733a
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / b00733a
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / b00733a
Reports root/ big
OK: 2773 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / b00733a
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / b00733a
Reports root/ big
OK: 1504 / Failed: 0 / User-skipped: 399 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / b00733a
Reports root/ big
OK: 1545 / Failed: 0 / User-skipped: 358 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / b00733a
Reports root/ big
OK: 1846 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / b00733a
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / b00733a
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / b00733a
Reports root/ big
OK: 3142 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / b00733a
Reports root/ big
OK: 3147 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / b00733a
Reports root/ big
OK: 1692 / Failed: 0 / User-skipped: 365 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #3582 (b00733a) into master (7aff549) will increase coverage by 1.56%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3582      +/-   ##
==========================================
+ Coverage   79.26%   80.82%   +1.56%     
==========================================
  Files         424      425       +1     
  Lines       32274    32282       +8     
==========================================
+ Hits        25581    26092     +511     
+ Misses       6693     6190     -503     
Impacted Files Coverage Δ
src/gen_mod.erl 79.27% <ø> (-0.19%) ⬇️
src/global_distrib/mod_global_distrib_disco.erl 81.25% <33.33%> (+7.56%) ⬆️
...lobal_distrib/mod_global_distrib_mapping_redis.erl 94.80% <80.00%> (+0.03%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.70% <80.00%> (-0.14%) ⬇️
src/global_distrib/mod_global_distrib_mapping.erl 98.09% <100.00%> (-0.02%) ⬇️
...bal_distrib/mod_global_distrib_mapping_backend.erl 100.00% <100.00%> (ø)
src/global_distrib/mod_global_distrib_receiver.erl 80.00% <0.00%> (-1.12%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 90.52% <0.00%> (-1.06%) ⬇️
src/mod_muc_room.erl 76.97% <0.00%> (-0.12%) ⬇️
src/ejabberd_c2s.erl 88.72% <0.00%> (+0.07%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aff549...b00733a. Read the comment docs.

@chrzaszcz chrzaszcz marked this pull request as ready for review March 9, 2022 15:56
Copy link
Contributor

@gustawlippa gustawlippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One more to go...

@gustawlippa gustawlippa merged commit ef8b27c into master Mar 10, 2022
@gustawlippa gustawlippa deleted the mod_global_distrib_mapping-backend branch March 10, 2022 11:33
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants