Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod vcard graphql api #3639
Mod vcard graphql api #3639
Changes from all commits
28dd39a
2e5818e
f57f288
9bf8710
faf98c0
574f1bb
c807c9a
11cd084
4fa8c85
e2de5d6
9fe890e
0abcbb8
9121e93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE:
In documentation is stated:
Thus we cannot have these two tags together. I think it is a minor thing, but it's good to know that the user is allowed to add them together through our API.
Second thing is that GraphQL doesn't have the type for a unique list. So it is possible to put a list with a duplication even when vcard documentation requires only one.