Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction async requests #3643

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

NelsonVides
Copy link
Collaborator

This is useful for the async workers, in line with how executes and queries where extended to support gen_server async requests, now also transactions. This is not used in open source MIM but I do use it in custom code.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #3643 (199523f) into master (72db059) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3643      +/-   ##
==========================================
+ Coverage   81.03%   81.06%   +0.03%     
==========================================
  Files         428      428              
  Lines       31939    31942       +3     
==========================================
+ Hits        25882    25895      +13     
+ Misses       6057     6047      -10     
Impacted Files Coverage Δ
src/rdbms/mongoose_rdbms.erl 65.46% <100.00%> (+1.83%) ⬆️
...rc/smart_markers/mod_smart_markers_rdbms_async.erl 85.18% <0.00%> (-3.71%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 71.64% <0.00%> (-1.50%) ⬇️
src/mod_roster.erl 78.70% <0.00%> (-0.24%) ⬇️
src/mod_muc_log.erl 63.21% <0.00%> (ø)
src/mod_muc_room.erl 76.70% <0.00%> (+0.11%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 95.60% <0.00%> (+0.25%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 77.71% <0.00%> (+0.57%) ⬆️
src/logger/mongoose_log_filter.erl 79.45% <0.00%> (+1.36%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72db059...199523f. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented May 9, 2022

small_tests_24 / small_tests / 199523f
Reports root / small


small_tests_23 / small_tests / 199523f
Reports root / small


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 199523f
Reports root/ big
OK: 2861 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 199523f
Reports root/ big
OK: 2844 / Failed: 0 / User-skipped: 150 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 199523f
Reports root/ big
OK: 2861 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 199523f
Reports root/ big
OK: 1506 / Failed: 0 / User-skipped: 402 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 199523f
Reports root/ big
OK: 2861 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 199523f
Reports root/ big
OK: 1506 / Failed: 0 / User-skipped: 402 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 199523f
Reports root/ big
OK: 1547 / Failed: 0 / User-skipped: 361 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 199523f
Reports root/ big
OK: 3235 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 199523f
Reports root/ big
OK: 3235 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 199523f
Reports root/ big
OK: 1854 / Failed: 0 / User-skipped: 369 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 199523f
Reports root/ big
OK: 3241 / Failed: 1 / User-skipped: 147 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_1855@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_1855@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"CgpWncaPUfS7jZVG3U9W+Q==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


mssql_mnesia_24 / odbc_mssql_mnesia / 199523f
Reports root/ big
OK: 3235 / Failed: 0 / User-skipped: 142 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 199523f
Reports root/ big
OK: 1697 / Failed: 0 / User-skipped: 368 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit a5d00fc into master May 10, 2022
@chrzaszcz chrzaszcz deleted the rdbms_request_transactions branch May 10, 2022 10:25
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants