-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction async requests #3643
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3643 +/- ##
==========================================
+ Coverage 81.03% 81.06% +0.03%
==========================================
Files 428 428
Lines 31939 31942 +3
==========================================
+ Hits 25882 25895 +13
+ Misses 6057 6047 -10
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / 199523f small_tests_23 / small_tests / 199523f dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 199523f dynamic_domains_mysql_redis_24 / mysql_redis / 199523f dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 199523f ldap_mnesia_24 / ldap_mnesia / 199523f dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 199523f ldap_mnesia_23 / ldap_mnesia / 199523f internal_mnesia_24 / internal_mnesia / 199523f pgsql_mnesia_23 / pgsql_mnesia / 199523f pgsql_mnesia_24 / pgsql_mnesia / 199523f elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 199523f mysql_redis_24 / mysql_redis / 199523f pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_1855@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_1855@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"CgpWncaPUfS7jZVG3U9W+Q==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mssql_mnesia_24 / odbc_mssql_mnesia / 199523f riak_mnesia_24 / riak_mnesia / 199523f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This is useful for the async workers, in line with how executes and queries where extended to support gen_server async requests, now also transactions. This is not used in open source MIM but I do use it in custom code.