Use OTP 25 on circle ci #3667

arcusfelis · 2022-06-02T14:03:01Z

No description provided.

codecov · 2022-06-02T14:24:30Z

Codecov Report

Merging #3667 (7e0d827) into master (b5d8108) will increase coverage by 0.03%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master    #3667      +/-   ##
==========================================
+ Coverage   81.14%   81.17%   +0.03%     
==========================================
  Files         433      433              
  Lines       31909    31877      -32     
==========================================
- Hits        25892    25876      -16     
+ Misses       6017     6001      -16

Impacted Files	Coverage Δ
src/async_pools/mongoose_aggregator_worker.erl	`61.70% <ø> (ø)`
src/inbox/mod_inbox_rdbms_async.erl	`71.64% <ø> (+1.49%)`	⬆️
src/rdbms/mongoose_rdbms.erl	`66.31% <ø> (ø)`
src/rdbms/rdbms_queries.erl	`90.74% <ø> (ø)`
...rc/smart_markers/mod_smart_markers_rdbms_async.erl	`88.88% <ø> (ø)`
src/http_upload/mod_http_upload_s3.erl	`93.61% <81.25%> (-6.39%)`	⬇️
src/mod_muc_rdbms.erl	`95.20% <100.00%> (+0.07%)`	⬆️
src/config/mongoose_config_utils.erl	`64.28% <0.00%> (-4.47%)`	⬇️
src/pubsub/node_pep.erl	`77.77% <0.00%> (-3.71%)`	⬇️
src/auth/ejabberd_auth_dummy.erl	`68.18% <0.00%> (-1.39%)`	⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d8108...7e0d827. Read the comment docs.

Fixes 'SSL_get_peer_certificate failed' error in fast_tls on the server

mongoose-im · 2022-06-06T17:30:54Z

small_tests_24 / small_tests / 62875c2
Reports root / small

small_tests_25 / small_tests / 62875c2
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 62875c2
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 62875c2
Reports root/ big
OK: 2890 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 62875c2
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 62875c2
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 62875c2
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 62875c2
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 62875c2
Reports root/ big
OK: 3281 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 62875c2
Reports root/ big
OK: 1593 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 62875c2
Reports root/ big
OK: 1900 / Failed: 0 / User-skipped: 324 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 62875c2
Reports root/ big
OK: 3281 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 62875c2
Reports root/ big
OK: 3276 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 62875c2
Reports root/ big
OK: 1743 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 62875c2
Reports root/ big
OK: 3292 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_1986@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_1986@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"qpcLBBlvHcqP68RCKcgubg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

NelsonVides

LGTM! 👌🏽

chrzaszcz

Looks good in general, I added a few comments.

.circleci/template.yml

src/http_upload/mod_http_upload_s3.erl

src/mod_muc_rdbms.erl

mongoose-im · 2022-06-07T09:22:20Z

small_tests_24 / small_tests / 7e0d827
Reports root / small

small_tests_25 / small_tests / 7e0d827
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7e0d827
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 7e0d827
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 7e0d827
Reports root/ big
OK: 2890 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 7e0d827
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7e0d827
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 7e0d827
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 7e0d827
Reports root/ big
OK: 3292 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_1974@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_1974@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"Le2arF+YP+jyKz7ECMvyUQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / 7e0d827
Reports root/ big
OK: 1593 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 7e0d827
Reports root/ big
OK: 3292 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_1980@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_1980@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"QDV7xDcNMFqG7R116ycFMQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 7e0d827
Reports root/ big
OK: 3288 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4383}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4124}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4120}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 7e0d827
Reports root/ big
OK: 1900 / Failed: 0 / User-skipped: 324 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 7e0d827
Reports root/ big
OK: 1743 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 7e0d827
Reports root/ big
OK: 3281 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

small_tests_24 / small_tests / 7e0d827
Reports root / small

chrzaszcz

Looks good 👍

arcusfelis force-pushed the mu-otp25 branch from 7ebf2d2 to 84a0942 Compare June 2, 2022 14:09

Use OTP 25 on circle ci

2c05eb6

arcusfelis force-pushed the mu-otp25 branch from 84a0942 to 2c05eb6 Compare June 2, 2022 14:14