Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove domain/retries #3774

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Remove domain/retries #3774

merged 3 commits into from
Sep 27, 2022

Commits on Sep 26, 2022

  1. Prepare domains backend to allow retries 

    Current logic for domain deletion first checks that the domain exists,
then removes the domain, and then runs the remove_domain hook. But this
is a problem, because if any of the hooks fails, then retrying the
domain removal won’t work, because it will be stopped at the first check
for domain existence.

Here we instead mark the domain as "in progress for deletion", which
will already disable it, and only finally delete it _after_ all hook
handlers have run hopefully successfully.
    @NelsonVides
    NelsonVides committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    3eea77f View commit details
    Browse the repository at this point in the history

  2. Enable to notify of modules failing to remove their data

    @NelsonVides
    NelsonVides committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    b3c25aa View commit details
    Browse the repository at this point in the history

  3. Define Status in GraphQL schema

    @NelsonVides
    NelsonVides committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    471d300 View commit details
    Browse the repository at this point in the history