Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored hook handler in mod_event_pusher_push module #3782

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_event_pusher_push module to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 30, 2022

small_tests_24 / small_tests / 572b0d3
Reports root / small


small_tests_25 / small_tests / 572b0d3
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 572b0d3
Reports root/ big
OK: 1992 / Failed: 0 / User-skipped: 745 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 572b0d3
Reports root/ big
OK: 1992 / Failed: 0 / User-skipped: 745 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 572b0d3
Reports root/ big
OK: 3829 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 572b0d3
Reports root/ big
OK: 3829 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 572b0d3
Reports root/ big
OK: 3803 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 572b0d3
Reports root/ big
OK: 3829 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 572b0d3
Reports root/ big
OK: 2113 / Failed: 0 / User-skipped: 624 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 572b0d3
Reports root/ big
OK: 4214 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2469@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2469@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"nyagTJApZmWOiDk+RcWvqg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 572b0d3
Reports root/ big
OK: 2453 / Failed: 0 / User-skipped: 619 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 572b0d3
Reports root/ big
OK: 4203 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 572b0d3
Reports root/ big
OK: 4189 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 572b0d3
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 572b0d3
Reports root/ big
OK: 4219 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

vcard_SUITE:ro_full:retrieve_own_card
{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}}

Report log

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 82.82% // Head: 82.85% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (572b0d3) compared to base (975bb21).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3782      +/-   ##
==========================================
+ Coverage   82.82%   82.85%   +0.02%     
==========================================
  Files         531      531              
  Lines       34138    34138              
==========================================
+ Hits        28274    28284      +10     
+ Misses       5864     5854      -10     
Impacted Files Coverage Δ
src/event_pusher/mod_event_pusher_push.erl 94.79% <100.00%> (ø)
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/mod_muc.erl 74.23% <0.00%> (-0.24%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/mod_muc_room.erl 78.73% <0.00%> (+0.05%) ⬆️
src/ejabberd_c2s.erl 89.23% <0.00%> (+0.29%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.82% <0.00%> (+0.42%) ⬆️
src/inbox/mod_inbox_rdbms_async.erl 72.05% <0.00%> (+1.47%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.11% <0.00%> (+4.44%) ⬆️
src/async_pools/mongoose_aggregator_worker.erl 68.33% <0.00%> (+5.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pawlooss1 pawlooss1 marked this pull request as ready for review September 30, 2022 08:25
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👌🏽

@NelsonVides NelsonVides merged commit e38a0d4 into master Oct 4, 2022
@NelsonVides NelsonVides deleted the hooks/mod_event_pusher_push branch October 4, 2022 07:47
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants