-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored hook handler in mod_event_pusher_push module #3782
Conversation
small_tests_24 / small_tests / 572b0d3 small_tests_25 / small_tests / 572b0d3 ldap_mnesia_24 / ldap_mnesia / 572b0d3 ldap_mnesia_25 / ldap_mnesia / 572b0d3 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 572b0d3 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 572b0d3 dynamic_domains_mysql_redis_25 / mysql_redis / 572b0d3 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 572b0d3 internal_mnesia_25 / internal_mnesia / 572b0d3 pgsql_mnesia_24 / pgsql_mnesia / 572b0d3 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2469@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2469@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"nyagTJApZmWOiDk+RcWvqg==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 572b0d3 pgsql_mnesia_25 / pgsql_mnesia / 572b0d3 mysql_redis_25 / mysql_redis / 572b0d3 riak_mnesia_24 / riak_mnesia / 572b0d3 mssql_mnesia_25 / odbc_mssql_mnesia / 572b0d3 vcard_SUITE:ro_full:retrieve_own_card{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}} |
Codecov ReportBase: 82.82% // Head: 82.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3782 +/- ##
==========================================
+ Coverage 82.82% 82.85% +0.02%
==========================================
Files 531 531
Lines 34138 34138
==========================================
+ Hits 28274 28284 +10
+ Misses 5864 5854 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat 👌🏽
This PR changes all hook handlers in
mod_event_pusher_push
module togen_hook
format.