C2S/fix muc_light_legacy tests #3927
Conversation
The 'to' attribute is described in the MUC Light XEP. Also: remove test repetition, we are getting rid of it.
Previous code was adding the MUC prefix to an already prefixed domain. This resulted in a double prefix in the recently fixed test cases.
|
small_tests_24 / small_tests / e3bf0f2 small_tests_25 / small_tests / e3bf0f2 ldap_mnesia_24 / ldap_mnesia / e3bf0f2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e3bf0f2 ldap_mnesia_25 / ldap_mnesia / e3bf0f2 pgsql_mnesia_24 / pgsql_mnesia / e3bf0f2 dynamic_domains_mysql_redis_25 / mysql_redis / e3bf0f2 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e3bf0f2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / e3bf0f2 smart_markers_SUITE:regular:one2one:repeated_markers_produce_no_warnings{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_repeated_markers_produce_no_warnings_2720@domain.example.com/res1">>,
escalus_tcp,<0.31672.2>,
[{event_manager,<0.31656.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_repeated_markers_produce_no_warnings_2720">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.31656.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_repeated_markers_produce_no_warnings_2720">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_repeated_markers_produce_no_warnings_2720">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_repeated_markers_produce_no_warnings_2720">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"6dac7afa17c04d87">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{smart_markers_SUITE,
'-repeated_markers_produce_no_warnings/1-fun-1-',2,
[{file,
...smart_markers_SUITE:regular:one2one:marker_after_timestamp_for_threadid_can_be_fetched{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_marker_after_timestamp_for_threadid_can_be_fetched_2719@domain.example.com/res1">>,
escalus_tcp,<0.31679.2>,
[{event_manager,<0.31654.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_2719">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.31654.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_2719">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_marker_after_timestamp_for_threadid_can_be_fetched_2719">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_2719">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"26e82c01bf1c834b">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{smart_markers_SUITE,
...smart_markers_SUITE:regular:one2one:remove_markers_when_removed_user{error,{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},
ejabberd_auth,remove_user,
[{jid,<<"bob_remove_markers_when_removed_user_2717">>,
<<"domain.example.com">>,<<>>}]],
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{smart_markers_SUITE,'-remove_markers_when_removed_user/1-fun-2-',2,
[{file,"/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
{line,245}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}smart_markers_SUITE:regular:one2one:marker_after_timestamp_can_be_fetched{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_marker_after_timestamp_can_be_fetched_2718@domain.example.com/res1">>,
escalus_tcp,<0.31670.2>,
[{event_manager,<0.31642.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_can_be_fetched_2718">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.31642.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_can_be_fetched_2718">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_marker_after_timestamp_can_be_fetched_2718">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_marker_after_timestamp_can_be_fetched_2718">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"6cd0f2481436082c">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{smart_markers_SUITE,
'-marker_after_timestamp_can_be_fetched/1-fun-0-',2,
[{fil...internal_mnesia_25 / internal_mnesia / e3bf0f2 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / e3bf0f2 riak_mnesia_24 / riak_mnesia / e3bf0f2 pgsql_mnesia_25 / pgsql_mnesia / e3bf0f2 mysql_redis_25 / mysql_redis / e3bf0f2 mssql_mnesia_25 / odbc_mssql_mnesia / e3bf0f2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / e3bf0f2 |
Codecov ReportBase: 79.99% // Head: 80.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/mongoose_c2s #3927 +/- ##
========================================================
+ Coverage 79.99% 80.40% +0.41%
========================================================
Files 540 540
Lines 34198 34198
========================================================
+ Hits 27356 27498 +142
+ Misses 6842 6700 -142
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The goal is to make
muc_light_legacy_SUITEpass with the newmongoose_c2s.The new c2s implementation requires proper addressing of the stanzas, so the tests are amended according to https://esl.github.io/MongooseDocs/latest/open-extensions/muc_light/#451-requesting-a-blocking-list
There is also a small fix in the code.