-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check MUC domain in mod_mam_muc #3936
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 83.19% // Head: 83.19% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3936 +/- ##
==========================================
- Coverage 83.19% 83.19% -0.01%
==========================================
Files 534 534
Lines 34114 34118 +4
==========================================
+ Hits 28380 28383 +3
- Misses 5734 5735 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
0eb160f
to
e00ed75
Compare
This comment was marked as outdated.
This comment was marked as outdated.
e00ed75
to
c61862c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c61862c
to
d4356dc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments
(cherry picked from commit 08a6e5e)
6665364
to
a4d005d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a4d005d
to
917f30f
Compare
small_tests_24 / small_tests / 917f30f small_tests_25 / small_tests / 917f30f ldap_mnesia_24 / ldap_mnesia / 917f30f dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 917f30f dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 917f30f dynamic_domains_mysql_redis_25 / mysql_redis / 917f30f ldap_mnesia_25 / ldap_mnesia / 917f30f dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 917f30f pgsql_mnesia_24 / pgsql_mnesia / 917f30f internal_mnesia_25 / internal_mnesia / 917f30f elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 917f30f riak_mnesia_24 / riak_mnesia / 917f30f pgsql_mnesia_25 / pgsql_mnesia / 917f30f mysql_redis_25 / mysql_redis / 917f30f mssql_mnesia_25 / odbc_mssql_mnesia / 917f30f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR adds checking for the MUC domain when archiving messages. Previously, when
mod_mam_muc
was enabled formuc
it also stored messages formuc_light
domains that belonged to the same host type and vice versa. The MUC domain is now checked in the handler that archive messages.