-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable codecov with the new uploader #4013
Conversation
4a160f4
to
3364a4f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4013 +/- ##
==========================================
- Coverage 82.17% 82.16% -0.01%
==========================================
Files 535 535
Lines 33844 33850 +6
==========================================
+ Hits 27811 27813 +2
- Misses 6033 6037 +4
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
3364a4f
to
8bf9bc0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
8bf9bc0
to
802ab97
Compare
a4c1da7
to
d5027ed
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
small_tests_24 / small_tests / d5027ed small_tests_25_arm64 / small_tests / d5027ed small_tests_25 / small_tests / d5027ed ldap_mnesia_24 / ldap_mnesia / d5027ed dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d5027ed ldap_mnesia_25 / ldap_mnesia / d5027ed dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d5027ed pgsql_mnesia_24 / pgsql_mnesia / d5027ed dynamic_domains_mysql_redis_25 / mysql_redis / d5027ed dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d5027ed muc_SUITE:register:user_submits_registration_form{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"14467d5f18241444fd2956c42b2f6dae">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitchroom-62f8a05731">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"alice_user_submits_registration_form_2520@domain.example.com/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"14467d5f18241444fd2956c42b2f6dae">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
... internal_mnesia_25 / internal_mnesia / d5027ed pgsql_mnesia_25 / pgsql_mnesia / d5027ed elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d5027ed mysql_redis_25 / mysql_redis / d5027ed mssql_mnesia_25 / odbc_mssql_mnesia / d5027ed dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d5027ed |
The python uploader is now phased out [1] The new uploader is a binary executable for x86-64 (amd64), so there is no simple way of running it for arm64. However, the arm64 build for small tests shouldn't affect coverage anyway (the tests are exactly the same as for amd64), so it is just skipped for now until the uploader supports this arch, see issue [2] CODECOV_TOKEN needs to be used now because of issue [3] 1. https://docs.codecov.com/docs/deprecated-uploader-migration-guide#python-uploader 2. codecov/uploader#523 3. https://community.codecov.com/t/commit-sha-does-not-match-circle-build/4266
d5027ed
to
67dd4b0
Compare
small_tests_24 / small_tests / 67dd4b0 small_tests_25_arm64 / small_tests / 67dd4b0 small_tests_25 / small_tests / 67dd4b0 ldap_mnesia_24 / ldap_mnesia / 67dd4b0 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 67dd4b0 ldap_mnesia_25 / ldap_mnesia / 67dd4b0 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 67dd4b0 dynamic_domains_mysql_redis_25 / mysql_redis / 67dd4b0 pgsql_mnesia_24 / pgsql_mnesia / 67dd4b0 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 67dd4b0 internal_mnesia_25 / internal_mnesia / 67dd4b0 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 67dd4b0 mysql_redis_25 / mysql_redis / 67dd4b0 mssql_mnesia_25 / odbc_mssql_mnesia / 67dd4b0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for handling this
The python uploader is now phased out.
The new uploader is a binary executable for x86-64 (amd64), so there is no simple way of running it for arm64. However, the arm64 build for small tests shouldn't affect coverage anyway (the tests are exactly the same as for amd64), so it is just
skipped for now until the uploader supports this arch, see codecov/uploader#523
CODECOV_TOKEN
needs to be used now because of a known issue.