Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove riak #4035

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Remove riak #4035

merged 4 commits into from
Jun 15, 2023

Conversation

pawlooss1
Copy link
Member

This PR removes Riak completely from repository.

@mongoose-im
Copy link
Collaborator

small_tests_25_arm64 / small_tests / 4647521
Reports root / small

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 12, 2023 •
edited
Loading

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 9706c24
Reports root

small_tests_24 / small_tests / 9706c24
Reports root / small

small_tests_25 / small_tests / 9706c24
Reports root / small

small_tests_25_arm64 / small_tests / 9706c24
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 9706c24
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 9706c24
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 80 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 9706c24
Reports root/ big
OK: 4168 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 9706c24
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 9706c24
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 80 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 9706c24
Reports root/ big
OK: 2368 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 9706c24
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 9706c24
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 83 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 9706c24
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 9706c24
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 9706c24
Reports root/ big
OK: 4564 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 12, 2023 •
edited
Loading

small_tests_24 / small_tests / 04662e7
Reports root / small

small_tests_25 / small_tests / 04662e7
Reports root / small

small_tests_25_arm64 / small_tests / 04662e7
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 04662e7
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 04662e7
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 80 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 04662e7
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 04662e7
Reports root/ big
OK: 4168 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 04662e7
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 80 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 04662e7
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 83 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 04662e7
Reports root/ big
OK: 2368 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 04662e7
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 04662e7
Reports root/ big
OK: 2728 / Failed: 0 / User-skipped: 659 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 04662e7
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 04662e7
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 04662e7
Reports root/ big
OK: 4564 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jun 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.43 🎉

Comparison is base (a47d5b5) 82.21% compared to head (96d8a83) 83.64%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4035      +/-   ##
==========================================
+ Coverage   82.21%   83.64%   +1.43%     
==========================================
  Files         536      526      -10     
  Lines       33782    33133     -649     
==========================================
- Hits        27774    27715      -59     
+ Misses       6008     5418     -590
Impacted Files Coverage Δ
src/mam/mod_mam.erl 97.22% <ø> (-0.19%) ⬇️
src/mam/mod_mam_utils.erl 89.45% <ø> (+0.56%) ⬆️
src/mod_last.erl 87.50% <ø> (-0.50%) ⬇️
src/mod_private.erl 82.00% <ø> (-1.02%) ⬇️
src/mod_roster.erl 78.31% <ø> (-0.16%) ⬇️
src/mongoose_lib.erl 88.88% <ø> (+1.21%) ⬆️
src/offline/mod_offline.erl 76.40% <ø> (-0.40%) ⬇️
src/offline/mod_offline_backend.erl 95.23% <ø> (ø)
src/privacy/mod_privacy.erl 88.99% <ø> (-0.11%) ⬇️
src/wpool/mongoose_wpool.erl 81.13% <ø> (-2.05%) ⬇️
... and 2 more

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 14, 2023 •
edited
Loading

small_tests_24 / small_tests / 364d0be
Reports root / small

small_tests_25_arm64 / small_tests / 364d0be
Reports root / small

small_tests_25 / small_tests / 364d0be
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 364d0be
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 364d0be
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 80 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 364d0be
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 80 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 364d0be
Reports root/ big
OK: 4168 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 364d0be
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 364d0be
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 364d0be
Reports root/ big
OK: 2368 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 364d0be
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 83 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 364d0be
Reports root/ big
OK: 2728 / Failed: 0 / User-skipped: 659 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 364d0be
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 364d0be
Reports root/ big
OK: 4564 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 364d0be
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

@pawlooss1 pawlooss1 marked this pull request as ready for review June 15, 2023 08:05
chrzaszcz
chrzaszcz reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only have two minor comments 🔥

tools/vcard_search_schema.xml Show resolved Hide resolved
tools/mam_search_schema.xml Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 15, 2023 •
edited
Loading

small_tests_24 / small_tests / 96d8a83
Reports root / small

small_tests_25 / small_tests / 96d8a83
Reports root / small

small_tests_25_arm64 / small_tests / 96d8a83
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 96d8a83
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 96d8a83
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 80 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 96d8a83
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 96d8a83
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 80 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 96d8a83
Reports root/ big
OK: 4168 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 96d8a83
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 96d8a83
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 83 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 96d8a83
Reports root/ big
OK: 2368 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 96d8a83
Reports root/ big
OK: 2728 / Failed: 0 / User-skipped: 659 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 96d8a83
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 96d8a83
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 96d8a83
Reports root/ big
OK: 4564 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

chrzaszcz
chrzaszcz approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit ca0dbc1 into master Jun 15, 2023
@chrzaszcz chrzaszcz deleted the remove-riak branch June 15, 2023 11:38
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pawlooss1 @mongoose-im @chrzaszcz