CETS support for components #4047

arcusfelis · 2023-06-29T23:28:51Z

This PR addresses MIM-1929.

Proposed changes include:

backend support for components
uses updated CETS
added CETS backend
added config option

Bag support in CETS esl/cets#3

mongoose-im · 2023-06-29T23:37:45Z

small_tests_24 / small_tests / fabb9a9
Reports root / small

small_tests_25 / small_tests / fabb9a9
Reports root / small

small_tests_25_arm64 / small_tests / fabb9a9
Reports root / small

ldap_mnesia_24 / ldap_mnesia / fabb9a9
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fabb9a9
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / fabb9a9
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fabb9a9
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / fabb9a9
Reports root/ big
OK: 4172 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / fabb9a9
Reports root/ big
OK: 4571 / Failed: 0 / User-skipped: 99 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / fabb9a9
Reports root/ big
OK: 4195 / Failed: 0 / User-skipped: 93 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / fabb9a9
Reports root/ big
OK: 4571 / Failed: 0 / User-skipped: 99 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / fabb9a9
Reports root/ big
OK: 2370 / Failed: 0 / User-skipped: 692 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / fabb9a9
Reports root/ big
OK: 2730 / Failed: 0 / User-skipped: 671 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / fabb9a9
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 123 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / fabb9a9
Reports root/ big
OK: 4557 / Failed: 0 / User-skipped: 113 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / fabb9a9
Reports root/ big
OK: 4568 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

codecov · 2023-06-29T23:48:17Z

Codecov Report

Patch coverage: 94.16% and project coverage change: -0.05 ⚠️

Comparison is base (72975d1) 82.22% compared to head (8cda94d) 82.18%.

Additional details and impacted files

@@               Coverage Diff                @@
##           feature/cets    #4047      +/-   ##
================================================
- Coverage         82.22%   82.18%   -0.05%     
================================================
  Files               542      546       +4     
  Lines             34023    34052      +29     
================================================
+ Hits              27976    27985       +9     
- Misses             6047     6067      +20

Impacted Files	Coverage Δ
src/config/mongoose_config_spec.erl	`100.00% <ø> (ø)`
src/ejabberd_s2s_in.erl	`79.03% <0.00%> (ø)`
src/ejabberd_sup.erl	`78.57% <ø> (ø)`
src/mod_disco.erl	`87.50% <ø> (ø)`
src/ejabberd_router.erl	`61.22% <50.00%> (-17.35%)`	⬇️
src/component/mongoose_component_mnesia.erl	`91.66% <91.66%> (ø)`
src/component/mongoose_component.erl	`96.29% <96.29%> (ø)`
src/component/mongoose_component_backend.erl	`100.00% <100.00%> (ø)`
src/component/mongoose_component_cets.erl	`100.00% <100.00%> (ø)`
src/ejabberd_service.erl	`66.88% <100.00%> (-0.22%)`	⬇️
... and 3 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mongoose-im · 2023-06-30T03:59:46Z

small_tests_25_arm64 / small_tests / d74ee8b
Reports root / small

small_tests_24 / small_tests / d74ee8b
Reports root / small

small_tests_25 / small_tests / d74ee8b
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d74ee8b
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / d74ee8b
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d74ee8b
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / d74ee8b
Reports root/ big
OK: 4571 / Failed: 0 / User-skipped: 99 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / d74ee8b
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / d74ee8b
Reports root/ big
OK: 4172 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d74ee8b
Reports root/ big
OK: 4195 / Failed: 0 / User-skipped: 93 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / d74ee8b
Reports root/ big
OK: 2370 / Failed: 0 / User-skipped: 692 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d74ee8b
Reports root/ big
OK: 2730 / Failed: 0 / User-skipped: 671 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / d74ee8b
Reports root/ big
OK: 4568 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / d74ee8b
Reports root/ big
OK: 4557 / Failed: 0 / User-skipped: 113 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / d74ee8b
Reports root/ big
OK: 4571 / Failed: 0 / User-skipped: 99 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / d74ee8b
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 123 / Auto-skipped: 0

mongoose-im · 2023-06-30T05:10:56Z

small_tests_24 / small_tests / d22d39f
Reports root / small

small_tests_25 / small_tests / d22d39f
Reports root / small

small_tests_25_arm64 / small_tests / d22d39f
Reports root / small

ldap_mnesia_24 / ldap_mnesia / d22d39f
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d22d39f
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / d22d39f
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / d22d39f
Reports root/ big
OK: 4172 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d22d39f
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / d22d39f
Reports root/ big
OK: 4571 / Failed: 0 / User-skipped: 99 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d22d39f
Reports root/ big
OK: 4195 / Failed: 0 / User-skipped: 93 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / d22d39f
Reports root/ big
OK: 2370 / Failed: 0 / User-skipped: 692 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d22d39f
Reports root/ big
OK: 2730 / Failed: 0 / User-skipped: 671 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / d22d39f
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 123 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / d22d39f
Reports root/ big
OK: 4591 / Failed: 4 / User-skipped: 113 / Auto-skipped: 0

jingle_SUITE:all:jingle_session_is_established_and_terminated_by_initiator

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"bob_jingle_session_is_established_and_terminated_by_initiator_1556@localhost">>},
        {<<"to">>,
         <<"alice_jingle_session_is_established_and_terminated_by_initiator_1556@localhost/res1">>},
        {<<"id">>,<<"c5adc44f-3fa3-434f-9ffb-795141e2e757">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-info">>},
           {<<"sid">>,<<"e8b1f23f-972c-4839-bf9e-0d436234196b">>}],
          [{xmlel,<<"ringing">>,
             [{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
             []}]}]},
     "<iq from='bob_jingle_session_is_established_and_terminated_by_initiator_1556@localhost' to='alice_jingle_session_is_established_and_terminated_by_initiator_1556@localhost/res1' id='c5adc44f-3fa3-434f-9ffb-795141e2e757' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='e8b1f23f-972c-4839-bf9e-0d436234196b'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
       {line,389}]},
    {jingle_SUITE,initiate_jingle_session,2,
     ...

Report log

jingle_SUITE:all:jingle_session_is_established_for_full_jids_on_different_nodes

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"clusterguy_jingle_session_is_established_for_full_jids_on_different_nodes_1554@localhost">>},
        {<<"to">>,
         <<"alice_jingle_session_is_established_for_full_jids_on_different_nodes_1554@localhost/res1">>},
        {<<"id">>,<<"b9634bd5-55fc-4ded-93a1-94d5abe921c4">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-info">>},
           {<<"sid">>,<<"c1af7162-4f25-4586-ad46-63e3036dd1cf">>}],
          [{xmlel,<<"ringing">>,
             [{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
             []}]}]},
     "<iq from='clusterguy_jingle_session_is_established_for_full_jids_on_different_nodes_1554@localhost' to='alice_jingle_session_is_established_for_full_jids_on_different_nodes_1554@localhost/res1' id='b9634bd5-55fc-4ded-93a1-94d5abe921c4' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='c1af7162-4f25-4586-ad46-63e3036dd1cf'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
       {line,389}]},
    {jingle_SUIT...

Report log

jingle_SUITE:all:jingle_session_initiate_is_resent_on_demand

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"bob_jingle_session_initiate_is_resent_on_demand_1562@localhost">>},
        {<<"to">>,
         <<"alice_jingle_session_initiate_is_resent_on_demand_1562@localhost/res1">>},
        {<<"id">>,<<"e7c2f2f8-81d4-4dc5-bdd8-d9e67c8bd298">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-info">>},
           {<<"sid">>,<<"fe2e9d2a-9ecf-4563-8e02-e21e7b808371">>}],
          [{xmlel,<<"ringing">>,
             [{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
             []}]}]},
     "<iq from='bob_jingle_session_initiate_is_resent_on_demand_1562@localhost' to='alice_jingle_session_initiate_is_resent_on_demand_1562@localhost/res1' id='e7c2f2f8-81d4-4dc5-bdd8-d9e67c8bd298' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='fe2e9d2a-9ecf-4563-8e02-e21e7b808371'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
       {line,389}]},
    {jingle_SUITE,initiate_jingle_session,2,
      [{file,"/home/circleci/project/big_tests/tests/jingle_S...

Report log

jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"error.480@localhost">>},
        {<<"to">>,
         <<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_1572@localhost/res1">>},
        {<<"id">>,<<"ed3b3bfa-ed77-4326-8ff4-9208ff9c6659">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-terminate">>},
           {<<"sid">>,<<"cdd6019c-e823-437e-b1dd-50926af573c9">>}],
          [{xmlel,<<"reason">>,[],
             [{xmlel,<<"general-error">>,[],[]},
            {xmlel,<<"sip-error">>,
              [{<<"code">>,<<"480">>}],
              [{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
     "<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_1572@localhost/res1' id='ed3b3bfa-ed77-4326-8ff4-9208ff9c6659' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='cdd6019c-e823-437e-b1dd-50926af573c9'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
       {line,389}]},
    {jingle_SUITE,
      '-resp_...

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / d22d39f
Reports root/ big
OK: 4568 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / d22d39f
Reports root/ big
OK: 4571 / Failed: 0 / User-skipped: 99 / Auto-skipped: 0

mongoose-im · 2023-06-30T05:31:04Z

small_tests_24 / small_tests / eaef9da
Reports root / small

small_tests_25_arm64 / small_tests / eaef9da
Reports root / small

small_tests_25 / small_tests / eaef9da
Reports root / small

ldap_mnesia_24 / ldap_mnesia / eaef9da
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / eaef9da
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / eaef9da
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / eaef9da
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / eaef9da
Reports root/ big
OK: 4192 / Failed: 3 / User-skipped: 93 / Auto-skipped: 0

rest_client_SUITE:roster:add_and_remove_some_contacts_with_nonexisting

{error,
  {{badmatch,
     {error,
       {connection_step_failed,
         {{escalus_session,authenticate},
          {client,
            <<"mike_add_and_remove_some_contacts_with_nonexisting_2643@domain.example.com/res1">>,
            escalus_tcp,<0.24695.2>,undefined,
            [{event_client,
               [{event_manager,<0.24619.2>},
              {server,<<"domain.example.com">>},
              {username,
                <<"mike_add_and_remove_some_contacts_with_nonexisting_2643">>},
              {resource,<<"res1">>}]},
             {resource,<<"res1">>},
             {username,
               <<"mike_add_and_remove_some_contacts_with_nonexisting_2643">>},
             {server,<<"domain.example.com">>},
             {host,<<"localhost">>},
             {port,5222},
             {auth,{escalus_auth,auth_plain}},
             {wspath,undefined},
             {username,
               <<"mike_add_and_remove_some_contacts_with_nonexisting_2643">>},
             {server,<<"domain.example.com">>},
             {host,<<"localhost">>},
             {password,<<"nicniema">>},
             {stream_id,<<"89cd734222177268">>}]},
          [{compression,false},
           {starttls,true},
           {stream_management,true},
           {advanced_message_processing,true},
           {client_state_indication,false},
           {sasl_mechanisms,[<<"SCRAM-SHA-256">>,<<"PLAIN">>]},
           {caps,undefined}]},
         {timeout,auth_reply}}}},
   [{escalus_story,'-start_ready_c...

Report log

rest_client_SUITE:roster:add_contact_and_be_invited

{error,{{assertion_failed,assert_many,false,
              [is_roster_set,is_iq_result],
              [],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {rest_client_SUITE,'-add_contact_and_be_invited/1-fun-1-',2,
              [{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
               {line,1249}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {rest_client_SUITE,add_contact_and_be_invited,1,
              [{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
               {line,1227}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

rest_client_SUITE:roster:add_and_remove

{error,{{badmatch,{{<<"500">>,<<"Internal Server Error">>},<<>>}},
    [{rest_client_SUITE,add_contact_check_roster_push,2,
              [{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
               {line,1390}]},
     {rest_client_SUITE,'-add_and_remove/1-fun-0-',2,
              [{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
               {line,1301}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {rest_client_SUITE,add_and_remove,1,
              [{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
               {line,1294}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / eaef9da
Reports root/ big
OK: 4172 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / eaef9da
Reports root/ big
OK: 2370 / Failed: 0 / User-skipped: 692 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / eaef9da
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 123 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / eaef9da
Reports root/ big
OK: 2730 / Failed: 0 / User-skipped: 671 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / eaef9da
Reports root/ big
OK: 4571 / Failed: 0 / User-skipped: 99 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / eaef9da
Reports root/ big
OK: 4557 / Failed: 0 / User-skipped: 113 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / eaef9da
Reports root/ big
OK: 4568 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / eaef9da
Reports root/ big
OK: 4195 / Failed: 0 / User-skipped: 93 / Auto-skipped: 0

pawlooss1

Great work 👍 I like that along with the new backend there is a separation of responsibilities with the new mongoose_component module. I left my few thoughts in the comments. Also, codecov is complaining that the node cleanup part is not covered by tests. Do you think there is a simple way of doing it? If it is not too complex then I think it is worth effort.

rebar.config

src/component/mongoose_component.erl

pawlooss1 · 2023-07-03T09:42:01Z

src/component/mongoose_component.erl

+    Checks = lists:map(fun is_already_registered/1, Components),
+    Zip = lists:zip(Components, Checks),
+    ConfictDomains =
+        [LDomain || {#external_component{domain = LDomain}, true} <- Zip],


I though of an alternative way of writing this which is more straightforward in my opinion:

ConflictComponents = lists:filter(fun is_already_registered/1, Components), ConflictDomains = [LDomain || #external_component{domain = LDomain} <- ConflictComponents]

Use it if you also like it.

src/config/mongoose_config_spec.erl

test/config_parser_SUITE.erl

chrzaszcz

The code looks good in general. Could you add some description to the PR (or details in commit messages) about how you replaced the two ETS tables with one of type bag and link to the PR for cets introducing the support for bag?

rebar.config

chrzaszcz · 2023-07-04T07:15:54Z

src/component/mongoose_component.erl

+assert_can_register_components(Components) ->
+    Checks = lists:map(fun is_already_registered/1, Components),
+    Zip = lists:zip(Components, Checks),
+    ConfictDomains =


Suggested change

ConfictDomains =

ConflictDomains =

src/config/mongoose_config_spec.erl

test/config_parser_SUITE.erl

Make mongoose_component_backend

mongoose-im · 2023-07-11T10:57:41Z

small_tests_24 / small_tests / 8cda94d
Reports root / small

small_tests_25_arm64 / small_tests / 8cda94d
Reports root / small

small_tests_25 / small_tests / 8cda94d
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8cda94d
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 8cda94d
Reports root/ big
OK: 2223 / Failed: 1 / User-skipped: 838 / Auto-skipped: 0

mod_global_distrib_SUITE:hosts_refresher:test_host_refreshing

{error,
  {{trees_for_connections_present,true,[{times,50,false}],ok},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,371}]},
    {mod_global_distrib_SUITE,test_host_refreshing,1,
      [{file,
         "/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
       {line,384}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_25 / ldap_mnesia / 8cda94d
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8cda94d
Reports root/ big
OK: 4198 / Failed: 0 / User-skipped: 90 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 8cda94d
Reports root/ big
OK: 4570 / Failed: 1 / User-skipped: 99 / Auto-skipped: 0

mod_global_distrib_SUITE:hosts_refresher:test_host_refreshing

{error,
  {{trees_for_connections_present,true,[{times,50,false}],ok},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,371}]},
    {mod_global_distrib_SUITE,test_host_refreshing,1,
      [{file,
         "/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
       {line,384}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8cda94d
Reports root/ big
OK: 4195 / Failed: 0 / User-skipped: 93 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / 8cda94d
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 123 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 8cda94d
Reports root/ big
OK: 4172 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8cda94d
Reports root/ big
OK: 2730 / Failed: 0 / User-skipped: 671 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 8cda94d
Reports root/ big
OK: 2370 / Failed: 0 / User-skipped: 692 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 8cda94d
Reports root/ big
OK: 4571 / Failed: 0 / User-skipped: 99 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 8cda94d
Reports root/ big
OK: 4568 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 8cda94d
Reports root/ big
OK: 4556 / Failed: 1 / User-skipped: 113 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join

{error,{test_case_failed,{[<<"example1.com">>],
              [<<"example1.com">>,<<"example2.com">>]}}}

Report log

ldap_mnesia_24 / ldap_mnesia / 8cda94d
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 838 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 8cda94d
Reports root/ big
OK: 4557 / Failed: 0 / User-skipped: 113 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 8cda94d
Reports root/ big
OK: 4571 / Failed: 0 / User-skipped: 99 / Auto-skipped: 0

chrzaszcz

Looks good 👍

pawlooss1

👌

arcusfelis changed the base branch from master to feature/cets June 29, 2023 23:29

arcusfelis added the WIP 🚧 label Jun 29, 2023

arcusfelis changed the title ~~[WIP] CETS support for components~~ CETS support for components Jun 30, 2023

arcusfelis added waiting-for-review and removed WIP 🚧 labels Jun 30, 2023

pawlooss1 self-requested a review July 3, 2023 08:48

pawlooss1 reviewed Jul 3, 2023

View reviewed changes

chrzaszcz reviewed Jul 4, 2023

View reviewed changes

arcusfelis added WIP 🚧 and removed waiting-for-review labels Jul 4, 2023

arcusfelis added 9 commits July 11, 2023 11:26

Move code into mongoose_component

46fe85a

Make mongoose_component_backend

Fix dialyzer

c8a16bb

Fix tests

ceb2881

Add mongoose_component_cets

5600487

Fix component_reg_SUITE

baf6026

Delete old external_componenst schema

f37241e

Fix muc_light_SUITE

c58a0d2

Fixes from review comments

0b58e50

Add test for node_cleanup for components

8cda94d

arcusfelis force-pushed the mu-cets-components branch from eaef9da to 8cda94d Compare July 11, 2023 10:48

arcusfelis removed the WIP 🚧 label Jul 11, 2023

arcusfelis requested review from chrzaszcz and pawlooss1 July 11, 2023 13:14

chrzaszcz approved these changes Jul 13, 2023

View reviewed changes

pawlooss1 approved these changes Jul 13, 2023

View reviewed changes

pawlooss1 merged commit 8d30969 into feature/cets Jul 13, 2023

pawlooss1 deleted the mu-cets-components branch July 13, 2023 09:44

chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CETS support for components #4047

CETS support for components #4047

arcusfelis commented Jun 29, 2023 •

edited

Loading

mongoose-im commented Jun 29, 2023 •

edited

Loading

codecov bot commented Jun 29, 2023 •

edited

Loading

mongoose-im commented Jun 30, 2023 •

edited

Loading

mongoose-im commented Jun 30, 2023 •

edited

Loading

mongoose-im commented Jun 30, 2023 •

edited

Loading

pawlooss1 left a comment

pawlooss1 Jul 3, 2023

chrzaszcz left a comment

chrzaszcz Jul 4, 2023

mongoose-im commented Jul 11, 2023 •

edited

Loading

chrzaszcz left a comment

pawlooss1 left a comment

CETS support for components #4047

CETS support for components #4047

Conversation

arcusfelis commented Jun 29, 2023 • edited Loading

mongoose-im commented Jun 29, 2023 • edited Loading

codecov bot commented Jun 29, 2023 • edited Loading

Codecov Report

mongoose-im commented Jun 30, 2023 • edited Loading

mongoose-im commented Jun 30, 2023 • edited Loading

mongoose-im commented Jun 30, 2023 • edited Loading

pawlooss1 left a comment

Choose a reason for hiding this comment

pawlooss1 Jul 3, 2023

Choose a reason for hiding this comment

chrzaszcz left a comment

Choose a reason for hiding this comment

chrzaszcz Jul 4, 2023

Choose a reason for hiding this comment

mongoose-im commented Jul 11, 2023 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

pawlooss1 left a comment

Choose a reason for hiding this comment

arcusfelis commented Jun 29, 2023 •

edited

Loading

mongoose-im commented Jun 29, 2023 •

edited

Loading

codecov bot commented Jun 29, 2023 •

edited

Loading

mongoose-im commented Jun 30, 2023 •

edited

Loading

mongoose-im commented Jun 30, 2023 •

edited

Loading

mongoose-im commented Jun 30, 2023 •

edited

Loading

mongoose-im commented Jul 11, 2023 •

edited

Loading