Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix muc_light_rooms.id key deifinition on MariaDB #4195

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Dec 20, 2023

Fixes error with MariaDB when applying schema:

ERROR 1901 (HY000) at line 319: Function or expression 'AUTO_INCREMENT' cannot be used in the USING HASH

This PR addresses MIM-2135:

Proposed changes include:

  • Use btree instead of hash.

Fixes error with MariaDB:
ERROR 1901 (HY000) at line 319:
Function or expression 'AUTO_INCREMENT' cannot be used in the USING HASH
@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 20, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 1e3f953
Reports root/ big
OK: 370 / Failed: 0 / User-skipped: 40 / Auto-skipped: 0


small_tests_25 / small_tests / 1e3f953
Reports root / small


small_tests_26 / small_tests / 1e3f953
Reports root / small


small_tests_26_arm64 / small_tests / 1e3f953
Reports root / small


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1e3f953
Reports root/ big
OK: 4239 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 1e3f953
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 1e3f953
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 1e3f953
Reports root/ big
OK: 4239 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 1e3f953
Reports root/ big
OK: 2408 / Failed: 0 / User-skipped: 707 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 1e3f953
Reports root/ big
OK: 4206 / Failed: 0 / User-skipped: 135 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 1e3f953
Reports root/ big
OK: 4236 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 1e3f953
Reports root/ big
OK: 4283 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 1e3f953
Reports root/ big
OK: 4628 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 1e3f953
Reports root/ big
OK: 4628 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 1e3f953
Reports root/ big
OK: 4607 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 1e3f953
Reports root/ big
OK: 4625 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:end_per_group
{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_domain_admin_create_room_no_permission_1090">>,
     [{escalus_event_mgr,<0.24723.0>},
    {tc_name,domain_admin_create_room_no_permission},
    {escalus_cleaner,<0.24722.0>},
    {watchdog,<0.24721.0>},
    {muc_light_host,<<"muclight.localhost">>},
    {secondary_muc_light_host,<<"muclight.localhost.bis">>},
    {protocol,http},
    {domain_admin,{<<"admin@localhost">>,<<"f710f8daa1288125">>}},
    {schema_endpoint,domain_admin},
    {{ejabberd_cwd,mongooseim@localhost},
     "/home/circleci/project/_build/mim1/rel/mongooseim"},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4195/204005/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40e84896a28784.2023-12-20_12.31.47/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-20_12.36.05/graphql_muc_light_suite.domain_admin_create_room_no_permission.html"},
    {tc_group_properties,[{name,domain_admin_muc_light}]},
    {tc_group_path,[[{name,domain_admin}]]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4195/204005/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40e84896a28784.2023-12-20_12.31.47/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-20_12.36.05/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"localhost">>},
     #{mod_vcard =...

Report log

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b29ab06) 84.29% compared to head (1e3f953) 84.31%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4195      +/-   ##
==========================================
+ Coverage   84.29%   84.31%   +0.02%     
==========================================
  Files         551      551              
  Lines       33473    33473              
==========================================
+ Hits        28215    28222       +7     
+ Misses       5258     5251       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review December 20, 2023 14:38
Copy link
Member

@pawlooss1 pawlooss1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pawlooss1 pawlooss1 merged commit dc7cef6 into master Dec 20, 2023
4 checks passed
@pawlooss1 pawlooss1 deleted the fix-muc_light_rooms-id-key-on-maria-db branch December 20, 2023 14:47
@jacekwegr jacekwegr added this to the 6.2.1 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants