-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mam disco barejid changes #4202
Conversation
d46cdec
to
b9ca511
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / d46cdec small_tests_25 / small_tests / d46cdec small_tests_26 / small_tests / d46cdec small_tests_26_arm64 / small_tests / d46cdec ldap_mnesia_25 / ldap_mnesia / d46cdec ldap_mnesia_26 / ldap_mnesia / d46cdec dynamic_domains_mysql_redis_26 / mysql_redis / d46cdec mod_ping_SUITE:client_ping:disco{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_disco_2332">>,<<"domain.example.com">>,
<<"matygrysa">>],
3000,mongooseim],
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d46cdec metrics_c2s_SUITE:single:presence_direct_one{error,
{{xmppPresenceReceived,
{value,3067},
[{times,25,
{error,
{badmatch,{value,3068}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,361}]},
{metrics_c2s_SUITE,'-presence_direct_one/1-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/metrics_c2s_SUITE.erl"},
{line,143}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}],
ok},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,358}]},
{metrics_c2s_SUITE,'-presence_direct_one/1-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/metrics_c2s_SUITE.erl"},
{line,143}]},
{escalus_story,story,4,
[{file,
"/home/circleci/... dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / d46cdec internal_mnesia_26 / internal_mnesia / d46cdec pubsub_SUITE:tree+basic:publish_only_retract_items_scope_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-publish_only_retract_items_scope_test/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,645}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} pubsub_SUITE:tree+basic:publish_with_max_items_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / d46cdec pgsql_mnesia_25 / pgsql_mnesia / d46cdec pgsql_cets_26 / pgsql_cets / d46cdec mysql_redis_26 / mysql_redis / d46cdec pgsql_mnesia_26 / pgsql_mnesia / d46cdec mssql_mnesia_26 / odbc_mssql_mnesia / d46cdec dynamic_domains_mysql_redis_26 / mysql_redis / d46cdec carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_583@domain.example.com">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_583@domain.example.com/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_583@domain.example.com/res1">>},
{<<"type">>,<<"chat">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_583@domain.example.com/res1">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_c... ldap_mnesia_26 / ldap_mnesia / d46cdec dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d46cdec internal_mnesia_26 / internal_mnesia / d46cdec dynamic_domains_mysql_redis_26 / mysql_redis / d46cdec |
149963a
to
3f93aa1
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / b9ca511 small_tests_25 / small_tests / b9ca511 small_tests_26 / small_tests / b9ca511 small_tests_26_arm64 / small_tests / b9ca511 ldap_mnesia_25 / ldap_mnesia / b9ca511 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b9ca511 dynamic_domains_mysql_redis_26 / mysql_redis / b9ca511 ldap_mnesia_26 / ldap_mnesia / b9ca511 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / b9ca511 internal_mnesia_26 / internal_mnesia / b9ca511 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / b9ca511 pgsql_mnesia_25 / pgsql_mnesia / b9ca511 mysql_redis_26 / mysql_redis / b9ca511 pgsql_cets_26 / pgsql_cets / b9ca511 pgsql_mnesia_26 / pgsql_mnesia / b9ca511 mssql_mnesia_26 / odbc_mssql_mnesia / b9ca511 graphql_muc_light_SUITE:user:user_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,2},
{unregistered_items,
[{{<<"_user_delete_room_1089">>,
[{escalus_event_mgr,<0.23212.0>},
{tc_name,user_delete_room},
{escalus_cleaner,<0.23211.0>},
{watchdog,<0.23210.0>},
{muc_light_host,<<"muclight.localhost">>},
{secondary_muc_light_host,<<"muclight.localhost.bis">>},
{schema_endpoint,user},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4202/204748/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4090cfaf07d31b.2024-01-03_08.46.43/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-01-03_08.51.23/graphql_muc_light_suite.user_delete_room.55682.html"},
{tc_group_properties,[{name,user_muc_light},parallel]},
{tc_group_path,[[{name,user}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4202/204748/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4090cfaf07d31b.2024-01-03_08.46.43/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-01-03_08.51.23/log_private/"},
{{saved_modules,mongooseim@localhost,<<"localhost">>},
#{mod_vcard =>
#{matches => 30,
host => {prefix,<<"vjud.">>},
search => true,iqdisc => parallel,backend => rdbms},
mod_roster =>
#{iqdisc => ... service_domain_db_SUITE:db:db_record_is_ignored_if_domain_static{error,
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,140}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1124}]},
{service_domain_db_SUITE,db_record_is_ignored_if_domain_static,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,540}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} service_domain_db_SUITE:db:db_events_table_gets_truncated{error,{{timeout,1307,
[{times,30,60},
{times,10,67},
{times,9,83},
{times,1,466},
{times,4,88},
{times,5,55},
{times,1,784},
{times,9,366},
{times,9,467},
{times,1,75},
{times,9,113},
{times,4,438},
{times,6,75},
{times,5,281},
{times,5,55},
{times,9,69},
{times,1,609},
{times,9,75},
{times,10,361},
{times,1,874},
{times,9,609},
{times,3,844}],
ok},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,358}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} service_domain_db_SUITE:db:db_get_all_static{error,
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,140}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1124}]},
{service_domain_db_SUITE,sync,0,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1103}]},
{service_domain_db_SUITE,db_get_all_static,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,340}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} service_domain_db_SUITE:db:db_could_sync_between_nodes{error,
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,140}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1124}]},
{service_domain_db_SUITE,sync,0,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1103}]},
{service_domain_db_SUITE,db_could_sync_between_nodes,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,565}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} mssql_mnesia_26 / odbc_mssql_mnesia / b9ca511 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4202 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 549 549
Lines 33431 33431
=======================================
Hits 28187 28187
Misses 5244 5244 ☔ View full report in Codecov by Sentry. |
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 3f93aa1 small_tests_25 / small_tests / 3f93aa1 small_tests_26 / small_tests / 3f93aa1 small_tests_26_arm64 / small_tests / 3f93aa1 ldap_mnesia_25 / ldap_mnesia / 3f93aa1 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 3f93aa1 ldap_mnesia_26 / ldap_mnesia / 3f93aa1 dynamic_domains_mysql_redis_26 / mysql_redis / 3f93aa1 carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_587@domain.example.com">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_587@domain.example.com/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_587@domain.example.com/res1">>},
{<<"type">>,<<"chat">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_587@domain.example.com/res1">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_c... dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 3f93aa1 internal_mnesia_26 / internal_mnesia / 3f93aa1 mysql_redis_26 / mysql_redis / 3f93aa1 pgsql_mnesia_26 / pgsql_mnesia / 3f93aa1 pgsql_cets_26 / pgsql_cets / 3f93aa1 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 3f93aa1 graphql_muc_light_SUITE:admin_http:admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,2},
{unregistered_items,
[{{<<"_admin_change_room_config_errors_1060">>,
[{escalus_event_mgr,<0.23640.0>},
{tc_name,admin_change_room_config_errors},
{escalus_cleaner,<0.23639.0>},
{watchdog,<0.23638.0>},
{muc_light_host,<<"muclight.domain.example.com">>},
{secondary_muc_light_host,<<"muclight.domain.example.org">>},
{protocol,http},
{schema_endpoint,admin},
{listener_opts,
#{module => mongoose_graphql_handler,path => "/api/graphql",
host => "localhost",username => <<"admin">>,
password => <<"secret">>,schema_endpoint => admin}},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4202/204779/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40f0d36cf7f0cd.2024-01-03_08.52.25/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-01-03_08.57.28/graphql_muc_light_suite.admin_change_room_config_errors.html"},
{tc_group_properties,[{name,admin_muc_light}]},
{tc_group_path,[[{name,admin_http}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4202/204779/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40f0d36cf7f0cd.2024-01-03_08.52.25/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-... pgsql_mnesia_25 / pgsql_mnesia / 3f93aa1 mssql_mnesia_26 / odbc_mssql_mnesia / 3f93aa1 dynamic_domains_mysql_redis_26 / mysql_redis / 3f93aa1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I added one comment
big_tests/tests/mam_SUITE.erl
Outdated
@@ -2947,6 +2951,16 @@ mam_service_discovery_to_client_bare_jid(Config) -> | |||
end, | |||
escalus_fresh:story(Config, [{alice, 1}], F). | |||
|
|||
mam_service_discovery_to_different_client_bare_jid_results_in_error(Config) -> | |||
_P = ?config(props, Config), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but the line is present in other test functions, both above and below. I can try deleting it, but should I remove it from other test function if it is not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove it from all of them, because it doesn't seem to do anything.
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / c1828ec small_tests_25 / small_tests / c1828ec small_tests_26 / small_tests / c1828ec small_tests_26_arm64 / small_tests / c1828ec ldap_mnesia_25 / ldap_mnesia / c1828ec dynamic_domains_mysql_redis_26 / mysql_redis / c1828ec dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c1828ec ldap_mnesia_26 / ldap_mnesia / c1828ec dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / c1828ec internal_mnesia_26 / internal_mnesia / c1828ec mysql_redis_26 / mysql_redis / c1828ec dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / c1828ec pgsql_cets_26 / pgsql_cets / c1828ec pgsql_mnesia_25 / pgsql_mnesia / c1828ec pgsql_mnesia_26 / pgsql_mnesia / c1828ec mssql_mnesia_26 / odbc_mssql_mnesia / c1828ec dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / c1828ec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Adding test to check if sending disco to different jid results in errror.