-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky GraphQL MUC light tests #4246
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4246 +/- ##
=======================================
Coverage 84.40% 84.41%
=======================================
Files 552 552
Lines 33549 33549
=======================================
+ Hits 28318 28319 +1
+ Misses 5231 5230 -1 ☔ View full report in Codecov by Sentry. |
2f14744
to
e6cc24e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
e6cc24e
to
33f5167
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 33f5167 small_tests_25 / small_tests / 33f5167 small_tests_26 / small_tests / 33f5167 small_tests_26_arm64 / small_tests / 33f5167 ldap_mnesia_26 / ldap_mnesia / 33f5167 ldap_mnesia_25 / ldap_mnesia / 33f5167 dynamic_domains_mysql_redis_26 / mysql_redis / 33f5167 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 33f5167 internal_mnesia_26 / internal_mnesia / 33f5167 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 33f5167 pgsql_cets_26 / pgsql_cets / 33f5167 pgsql_mnesia_25 / pgsql_mnesia / 33f5167 graphql_SUITE:tls_enabled:tls_connect_admin_selfsigned_certificate{error,{{assertMatch,[{module,graphql_SUITE},
{line,259},
{expression,"Result"},
{pattern,"{ error , { tls_alert , { bad_certificate , _ } } }"},
{value,{error,connection_closed}}]},
[{graphql_SUITE,tls_connect_admin_selfsigned_certificate,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_SUITE.erl"},
{line,259}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mysql_redis_26 / mysql_redis / 33f5167 pgsql_mnesia_26 / pgsql_mnesia / 33f5167 mssql_mnesia_26 / odbc_mssql_mnesia / 33f5167 ldap_mnesia_25 / ldap_mnesia / 33f5167 pgsql_mnesia_25 / pgsql_mnesia / 33f5167 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I only added one comment.
case mongoose_helper:is_rdbms_enabled(domain_helper:host_type()) of | ||
true -> | ||
F = fun() -> rpc(mim(), mod_muc_light_db_rdbms, force_clear, []) end, | ||
mongoose_helper:wait_until(F, ok); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... why do we call it with wait_until
if this function can only return ok
? It looks like we never wait, and you could just call force_clear
directly.
33f5167
to
e7678b3
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / e7678b3 small_tests_25 / small_tests / e7678b3 small_tests_26 / small_tests / e7678b3 small_tests_26_arm64 / small_tests / e7678b3 ldap_mnesia_25 / ldap_mnesia / e7678b3 dynamic_domains_mysql_redis_26 / mysql_redis / e7678b3 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e7678b3 ldap_mnesia_26 / ldap_mnesia / e7678b3 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / e7678b3 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / e7678b3 internal_mnesia_26 / internal_mnesia / e7678b3 pgsql_cets_26 / pgsql_cets / e7678b3 pgsql_mnesia_25 / pgsql_mnesia / e7678b3 pgsql_mnesia_26 / pgsql_mnesia / e7678b3 mysql_redis_26 / mysql_redis / e7678b3 mssql_mnesia_26 / odbc_mssql_mnesia / e7678b3 elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / e7678b3 small_tests_25 / small_tests / e7678b3 small_tests_26 / small_tests / e7678b3 small_tests_26_arm64 / small_tests / e7678b3 ldap_mnesia_25 / ldap_mnesia / e7678b3 graphql_server_SUITE:admin_cli:clustering_tests:remove_alive_from_cluster{failed,
{graphql_server_SUITE,end_per_testcase,
{'EXIT',
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mnesia,system_info,
[is_running]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,has_mnesia,1,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,31}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,53}]},
{graphql_server_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,121}]},
{test_server,do_end_per_testcase,4,
[{file,"test_server.erl"},{line,1626}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1334}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}}} graphql_server_SUITE:admin_cli:clustering_tests:remove_node_test{error,{#{expected_type => ok,
response_code => {exit_status,3},
what => invalid_response_code},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,remove_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,225}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:stop_node_test{error,{#{expected_type => ok,
response_code => {exit_status,3},
what => invalid_response_code},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,stop_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,230}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} jingle_SUITE:end_per_suite{error,
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,477}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim2@localhost,timeout => 30000},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{jingle_SUITE,end_per_suite,1,
[{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
{line,103}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1379}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} metrics_api_SUITE:all_metrics_are_global:end_per_group{error,
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,477}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim2@localhost,timeout => 30000},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{metrics_helper,finalise_by_all_metrics_are_global,2,
[{file,"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,55}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1379}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} metrics_api_SUITE:global:cluster_size{skip,
{failed,
{metrics_api_SUITE,init_per_testcase,
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,477}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim2@localhost,timeout => 30000},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{metrics_api_SUITE,'-ensure_nodes_not_clustered/1-lc$^1/1-1-',
2,
[{file,
"/home/circleci/project/big_tests/tests/metrics_api_SUITE.erl"},
{line,477}]},
{metrics_api_SUITE,ensure_nodes_not_clustered,1,
... mod_global_distrib_SUITE:end_per_suite{error,
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,477}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim2@localhost,timeout => 30000},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{mongoose_helper,successful_rpc,5,
[{file,
"/home/circleci/project/big_tests/../test/common/mongoose_helper.erl"},
{line,279}]},
{mod_global_distrib_SUITE,end_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
{line,139}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1379}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} persistent_cluster_id_SUITE:mnesia:all_nodes_in_the_cluster_have_the_same_cluster_id{failed,
{persistent_cluster_id_SUITE,end_per_testcase,
{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,477}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim2@localhost,timeout => 30000},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{persistent_cluster_id_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/persistent_cluster_id_SUITE.erl"},
{line,92}]},
{test_server,do_end_per_testcase,4,
[{file,"test_serve... service_mongoose_system_metrics_SUITE:all_clustered_mongooses_report_the_same_client_id{failed,
{service_mongoose_system_metrics_SUITE,end_per_testcase,
{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,477}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim2@localhost,timeout => 30000},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{service_mongoose_system_metrics_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,160}]},
{test_server,do_end_per_testcase,... service_mongoose_system_metrics_SUITE:log_transparency:just_removed_from_config_logs_question{error,
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_service,ensure_stopped,
[service_mongoose_system_metrics]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{service_mongoose_system_metrics_SUITE,disable_system_metrics,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,437}]},
{service_mongoose_system_metrics_SUITE,
just_removed_from_config_logs_question,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,283}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} service_domain_db_SUITE:init_per_suite{'EXIT',
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_service,loaded_services_with_opts,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{dynamic_services,save_services,2,
[{file,
"/home/circleci/project/big_tests/tests/dynamic_services.erl"},
{line,15}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{service_domain_db_SUITE,init_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,198}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1379}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_SUITE:end_per_suite{error,
{{badrpc,
{'EXIT',
{{badmatch,{[{atomic,ok}],[mongooseim3@localhost]}},
[{mongoose_cluster,detach_nodes,1,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,210}]},
{mongoose_cluster,'-do_leave/0-fun-0-',0,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,52}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,219}]},
{global,trans,4,[{file,"global.erl"},{line,477}]},
{mongoose_cluster,leave,0,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim2@localhost,timeout => 30000},
mongoose_cluster,leave,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,remove_node_from_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,55}]},
{dynamic_domains_SUITE,uncluster_nodes,2,
[{file,
"/home/circleci/project/big_tests/tests/dynamic_domains_SUITE.erl"},
{line,215}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1379}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_mysql_redis_26 / mysql_redis / e7678b3 ldap_mnesia_26 / ldap_mnesia / e7678b3 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e7678b3 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / e7678b3 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / e7678b3 graphql_SUITE:tls_enabled:tls_connect_admin_selfsigned_certificate{error,{{assertMatch,[{module,graphql_SUITE},
{line,259},
{expression,"Result"},
{pattern,"{ error , { tls_alert , { bad_certificate , _ } } }"},
{value,{error,connection_closed}}]},
[{graphql_SUITE,tls_connect_admin_selfsigned_certificate,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_SUITE.erl"},
{line,259}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} pgsql_mnesia_25 / pgsql_mnesia / e7678b3 pgsql_cets_26 / pgsql_cets / e7678b3 mysql_redis_26 / mysql_redis / e7678b3 pgsql_mnesia_26 / pgsql_mnesia / e7678b3 mssql_mnesia_26 / odbc_mssql_mnesia / e7678b3 internal_mnesia_26 / internal_mnesia / e7678b3 graphql_server_SUITE:admin_cli:clustering_tests:join_successful{error,{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,1}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,join_successful,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,153}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:leave_successful{error,{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,1}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,leave_successful,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,159}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:join_twice{error,{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,1}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,join_twice,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,174}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:leave_twice{error,{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,1}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,leave_twice,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,181}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:remove_dead_from_cluster{error,{{badrpc,timeout},
[{distributed_helper,rpc,
[#{timeout => 60000,
node => mongooseim2@localhost},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{graphql_server_SUITE,remove_dead_from_cluster,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,191}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:remove_alive_from_cluster{error,{{badrpc,timeout},
[{distributed_helper,rpc,
[#{timeout => 60000,
node => mongooseim2@localhost},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{graphql_server_SUITE,remove_alive_from_cluster,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,213}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_http:get_cluster_metrics{error,{{badmatch,#{<<"mongooseim@localhost">> =>
[#{<<"dict">> =>
[#{<<"key">> => <<"count">>,<<"value">> => 0},
#{<<"key">> => <<"one">>,<<"value">> => 0}],
<<"name">> =>
[<<"global">>,<<"backends">>,
<<"ejabberd_auth_anonymous">>,<<"calls">>,
<<"does_anonymous_user_exist">>]},
#{<<"dict">> =>
[#{<<"key">> => <<"n">>,<<"value">> => 0},
#{<<"key">> => <<"mean">>,<<"value">> => 0},
#{<<"key">> => <<"min">>,<<"value">> => 0},
#{<<"key">> => <<"max">>,<<"value">> => 0},
#{<<"key">> => <<"median">>,<<"value">> => 0},
#{<<"key">> => <<"50">>,<<"value">> => 0},
#{<<"key">> => <<"75">>,<<"value">> => 0},
#{<<"key">> => <<"90">>,<<"value">> => 0},
#{<<"key">> => <<"95">>,<<"value">> => 0},
#{<<"key">> => <<"99">>,<<"value">> => 0},
#{<<"key">> => <<"999">>,<<"value">> => 0}],
<<"name">> =>
[<<"global">>,<<"backends">>,
<<"ejabberd_auth_anonymous">>,
<<"does_anonymous_user_exist">>]},
#{<<"dict">> =>
[#{<<"key">> => <<"count">>,<<"value">> => 0},
#{<<"key">> => <<"one">>,<<"value">> => 0}],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
... graphql_metric_SUITE:metrics_http:get_by_name_cluster_metrics_as_dicts{error,{{assert,[{module,graphql_metric_SUITE},
{line,285},
{expression,"maps : size ( Map ) > 1"},
{expected,true},
{value,false}]},
[{graphql_metric_SUITE,get_by_name_cluster_metrics_as_dicts,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,285}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_http:get_mim2_cluster_metrics{error,{{badkey,[<<"global">>,<<"xmppStanzaSent">>]},
[{erlang,map_get,
[[<<"global">>,<<"xmppStanzaSent">>],
#{[<<"error">>,<<"nodedown">>] => []}],
[{error_info,#{module => erl_erts_errors}}]},
{graphql_metric_SUITE,check_node_result_is_valid,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,364}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_http:get_cluster_metrics_by_nonexistent_name{error,{{badmatch,[#{<<"node">> => <<"mongooseim@localhost">>,
<<"result">> => []}]},
[{graphql_metric_SUITE,get_cluster_metrics_by_nonexistent_name,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,310}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_http:get_cluster_metrics_with_nonexistent_key{error,{{badmatch,[#{<<"node">> => <<"mongooseim@localhost">>,
<<"result">> =>
[#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,
<<"ejabberd_auth_anonymous">>,<<"calls">>,
<<"does_anonymous_user_exist">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,
<<"ejabberd_auth_anonymous">>,
<<"does_anonymous_user_exist">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"del_roster_t">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"get_roster">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"get_roster_entry">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"get_subscription_lists">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"read_roster_version">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"g... graphql_metric_SUITE:metrics_http:get_cluster_metrics_empty_args{error,{{badkey,[<<"global">>,<<"xmppStanzaSent">>]},
[{erlang,map_get,
[[<<"global">>,<<"xmppStanzaSent">>],
#{[<<"error">>,<<"nodedown">>] => []}],
[{error_info,#{module => erl_erts_errors}}]},
{graphql_metric_SUITE,get_cluster_metrics_empty_args,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,327}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_http:get_cluster_metrics_empty_strings{error,{{badmatch,[#{<<"node">> => <<"mongooseim2@localhost">>,
<<"result">> =>
[#{<<"dict">> => [],
<<"name">> => [<<"error">>,<<"nodedown">>]}]}]},
[{graphql_metric_SUITE,get_cluster_metrics_empty_strings,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,345}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_cli:get_cluster_metrics{error,{{badmatch,#{<<"mongooseim@localhost">> =>
[#{<<"dict">> =>
[#{<<"key">> => <<"count">>,<<"value">> => 0},
#{<<"key">> => <<"one">>,<<"value">> => 0}],
<<"name">> =>
[<<"global">>,<<"backends">>,
<<"ejabberd_auth_anonymous">>,<<"calls">>,
<<"does_anonymous_user_exist">>]},
#{<<"dict">> =>
[#{<<"key">> => <<"n">>,<<"value">> => 0},
#{<<"key">> => <<"mean">>,<<"value">> => 0},
#{<<"key">> => <<"min">>,<<"value">> => 0},
#{<<"key">> => <<"max">>,<<"value">> => 0},
#{<<"key">> => <<"median">>,<<"value">> => 0},
#{<<"key">> => <<"50">>,<<"value">> => 0},
#{<<"key">> => <<"75">>,<<"value">> => 0},
#{<<"key">> => <<"90">>,<<"value">> => 0},
#{<<"key">> => <<"95">>,<<"value">> => 0},
#{<<"key">> => <<"99">>,<<"value">> => 0},
#{<<"key">> => <<"999">>,<<"value">> => 0}],
<<"name">> =>
[<<"global">>,<<"backends">>,
<<"ejabberd_auth_anonymous">>,
<<"does_anonymous_user_exist">>]},
#{<<"dict">> =>
[#{<<"key">> => <<"count">>,<<"value">> => 0},
#{<<"key">> => <<"one">>,<<"value">> => 0}],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
... graphql_metric_SUITE:metrics_cli:get_by_name_cluster_metrics_as_dicts{error,{{assert,[{module,graphql_metric_SUITE},
{line,285},
{expression,"maps : size ( Map ) > 1"},
{expected,true},
{value,false}]},
[{graphql_metric_SUITE,get_by_name_cluster_metrics_as_dicts,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,285}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_cli:get_mim2_cluster_metrics{error,{{badkey,[<<"global">>,<<"xmppStanzaSent">>]},
[{erlang,map_get,
[[<<"global">>,<<"xmppStanzaSent">>],
#{[<<"error">>,<<"nodedown">>] => []}],
[{error_info,#{module => erl_erts_errors}}]},
{graphql_metric_SUITE,check_node_result_is_valid,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,364}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_cli:get_cluster_metrics_by_nonexistent_name{error,{{badmatch,[#{<<"node">> => <<"mongooseim@localhost">>,
<<"result">> => []}]},
[{graphql_metric_SUITE,get_cluster_metrics_by_nonexistent_name,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,310}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_cli:get_cluster_metrics_with_nonexistent_key{error,{{badmatch,[#{<<"node">> => <<"mongooseim@localhost">>,
<<"result">> =>
[#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,
<<"ejabberd_auth_anonymous">>,<<"calls">>,
<<"does_anonymous_user_exist">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,
<<"ejabberd_auth_anonymous">>,
<<"does_anonymous_user_exist">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"del_roster_t">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"get_roster">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"get_roster_entry">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"get_subscription_lists">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"global">>,<<"backends">>,<<"mod_roster">>,
<<"calls">>,<<"read_roster_version">>]},
#{<<"dict">> => [],
<<"name">> =>
[<<"g... graphql_metric_SUITE:metrics_cli:get_cluster_metrics_empty_args{error,{{badkey,[<<"global">>,<<"xmppStanzaSent">>]},
[{erlang,map_get,
[[<<"global">>,<<"xmppStanzaSent">>],
#{[<<"error">>,<<"nodedown">>] => []}],
[{error_info,#{module => erl_erts_errors}}]},
{graphql_metric_SUITE,get_cluster_metrics_empty_args,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,327}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} graphql_metric_SUITE:metrics_cli:get_cluster_metrics_empty_strings{error,{{badmatch,[#{<<"node">> => <<"mongooseim2@localhost">>,
<<"result">> =>
[#{<<"dict">> => [],
<<"name">> => [<<"error">>,<<"nodedown">>]}]}]},
[{graphql_metric_SUITE,get_cluster_metrics_empty_strings,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_metric_SUITE.erl"},
{line,345}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} jingle_SUITE:init_per_suite{'EXIT',{{badrpc,timeout},
[{distributed_helper,rpc,
[#{timeout => 30000,
node => mongooseim2@localhost},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,add_node_to_mnesia_cluster,2,
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,44}]},
{distributed_helper,add_node_to_cluster,2,
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,36}]},
{jingle_SUITE,init_per_suite,1,
[{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
{line,61}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1390}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} metrics_api_SUITE:all_metrics_are_global:init_per_group{'EXIT',{{badrpc,timeout},
[{distributed_helper,rpc,
[#{timeout => 30000,
node => mongooseim2@localhost},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,add_node_to_mnesia_cluster,2,
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,44}]},
{distributed_helper,add_node_to_cluster,2,
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,36}]},
{metrics_helper,prepare_by_all_metrics_are_global,2,
[{file,"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,45}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1390}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} metrics_api_SUITE:global:cluster_size{error,{{badrpc,timeout},
[{distributed_helper,rpc,
[#{timeout => 30000,
node => mongooseim2@localhost},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,add_node_to_mnesia_cluster,2,
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,44}]},
{distributed_helper,add_node_to_cluster,2,
[{file,"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,36}]},
{metrics_api_SUITE,cluster_size,1,
[{file,"/home/circleci/project/big_tests/tests/metrics_api_SUITE.erl"},
{line,251}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} mod_global_distrib_SUITE:init_per_suite{'EXIT',
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{timeout => 30000,node => mongooseim2@localhost},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{mongoose_helper,successful_rpc,5,
[{file,
"/home/circleci/project/big_tests/../test/common/mongoose_helper.erl"},
{line,279}]},
{mod_global_distrib_SUITE,init_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
{line,125}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1390}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} persistent_cluster_id_SUITE:mnesia:all_nodes_in_the_cluster_have_the_same_cluster_id{skip,
{failed,
{persistent_cluster_id_SUITE,init_per_testcase,
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{timeout => 30000,node => mongooseim2@localhost},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{distributed_helper,add_node_to_mnesia_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,44}]},
{distributed_helper,add_node_to_cluster,2,
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,36}]},
{persistent_cluster_id_SUITE,init_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/persistent_cluster_id_SUITE.erl"},
{line,86}]},
{test_server,do_init_per_testcase,2,
[{file,"test_server.erl"},{line,1563}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1264}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}}} 6 errors were truncated pgsql_mnesia_25 / pgsql_mnesia / e7678b3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR fixes flaky tests in the
graphql_muc_light_SUITE
. The main cause of these issues was that occasionally the RDBMS database did not have enough time to clear out data. This led to tests failing due to problems like duplicate rooms.To fix this, the check has been added in the
end_per_group
to make sure the database is completely empty before moving on.The tests were run on repeat on CI to make sure the problem is truly fixed.