-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate SM session metrics to mongoose_instrument
#4313
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/instrument #4313 +/- ##
======================================================
- Coverage 84.65% 84.65% -0.01%
======================================================
Files 556 553 -3
Lines 33878 33867 -11
======================================================
- Hits 28681 28670 -11
Misses 5197 5197 ☔ View full report in Codecov by Sentry. |
724ab63
to
4a003e1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4a003e1
to
b58cdc5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b58cdc5
to
c9d896b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's going in the right direction. I added a few comments.
c9d896b
to
bf2e07b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bf2e07b
to
12e84b1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
12e84b1
to
146aa72
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 146aa72 small_tests_25 / small_tests / 146aa72 small_tests_26 / small_tests / 146aa72 small_tests_26_arm64 / small_tests / 146aa72 ldap_mnesia_25 / ldap_mnesia / 146aa72 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 146aa72 ldap_mnesia_26 / ldap_mnesia / 146aa72 dynamic_domains_mysql_redis_26 / mysql_redis / 146aa72 internal_mnesia_26 / internal_mnesia / 146aa72 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 146aa72 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 146aa72 mysql_redis_26 / mysql_redis / 146aa72 pgsql_mnesia_25 / pgsql_mnesia / 146aa72 pgsql_cets_26 / pgsql_cets / 146aa72 pgsql_mnesia_26 / pgsql_mnesia / 146aa72 mssql_mnesia_26 / odbc_mssql_mnesia / 146aa72 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👌
This PR includes the following:
mongoose_metrics_probe
tomongoose_instrument_probe
[global, cache, unique_sessions_number]
was removed because it relied on a specific metric backend and wasn't used anywhere else in the code