Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SM session metrics to mongoose_instrument #4313

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

jacekwegr
Copy link
Contributor

@jacekwegr jacekwegr commented Jun 27, 2024

This PR includes the following:

  • Changes the way we track user sessions by switching from mongoose_metrics_probe to mongoose_instrument_probe
  • Updates the tests to support these changed metrics
  • Updates the documentation about changed metrics
  • The metric [global, cache, unique_sessions_number] was removed because it relied on a specific metric backend and wasn't used anywhere else in the code

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.65%. Comparing base (bc5c502) to head (146aa72).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/instrument    #4313      +/-   ##
======================================================
- Coverage               84.65%   84.65%   -0.01%     
======================================================
  Files                     556      553       -3     
  Lines                   33878    33867      -11     
======================================================
- Hits                    28681    28670      -11     
  Misses                   5197     5197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr marked this pull request as ready for review July 1, 2024 08:05
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going in the right direction. I added a few comments.

src/ejabberd_sm.erl Outdated Show resolved Hide resolved
src/metrics/mongoose_metrics_probe_node_sessions.erl Outdated Show resolved Hide resolved
src/ejabberd_sm.erl Outdated Show resolved Hide resolved
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 3, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 146aa72
Reports root/ big
OK: 455 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0


small_tests_25 / small_tests / 146aa72
Reports root / small


small_tests_26 / small_tests / 146aa72
Reports root / small


small_tests_26_arm64 / small_tests / 146aa72
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 146aa72
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 146aa72
Reports root/ big
OK: 4612 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 146aa72
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 146aa72
Reports root/ big
OK: 4579 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 146aa72
Reports root/ big
OK: 2428 / Failed: 0 / User-skipped: 768 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 146aa72
Reports root/ big
OK: 4612 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 146aa72
Reports root/ big
OK: 4609 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 146aa72
Reports root/ big
OK: 4985 / Failed: 0 / User-skipped: 134 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 146aa72
Reports root/ big
OK: 5004 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 146aa72
Reports root/ big
OK: 4513 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 146aa72
Reports root/ big
OK: 5004 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 146aa72
Reports root/ big
OK: 5001 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@chrzaszcz chrzaszcz merged commit 6730fe5 into feature/instrument Jul 3, 2024
3 of 4 checks passed
@chrzaszcz chrzaszcz deleted the instrument/sm-session branch July 3, 2024 10:25
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants