-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split listeners documentation into multiple files #4327
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4327 +/- ##
==========================================
- Coverage 84.33% 84.31% -0.03%
==========================================
Files 553 553
Lines 33731 33731
==========================================
- Hits 28447 28440 -7
- Misses 5284 5291 +7 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This is how it's done for modules and auth methods.
c742a5c
to
d6347f1
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / d6347f1 small_tests_25 / small_tests / d6347f1 small_tests_26 / small_tests / d6347f1 small_tests_26_arm64 / small_tests / d6347f1 ldap_mnesia_25 / ldap_mnesia / d6347f1 ldap_mnesia_26 / ldap_mnesia / d6347f1 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d6347f1 dynamic_domains_mysql_redis_26 / mysql_redis / d6347f1 internal_mnesia_26 / internal_mnesia / d6347f1 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / d6347f1 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / d6347f1 pgsql_cets_26 / pgsql_cets / d6347f1 pgsql_mnesia_25 / pgsql_mnesia / d6347f1 pgsql_mnesia_26 / pgsql_mnesia / d6347f1 mysql_redis_26 / mysql_redis / d6347f1 mssql_mnesia_26 / odbc_mssql_mnesia / d6347f1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added one minor comment - not necessary to address.
Co-authored-by: Paweł Chrząszcz <pawel.chrzaszcz@erlang-solutions.com>
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / e6d3c4d small_tests_25 / small_tests / e6d3c4d small_tests_26 / small_tests / e6d3c4d small_tests_26_arm64 / small_tests / e6d3c4d ldap_mnesia_25 / ldap_mnesia / e6d3c4d ldap_mnesia_26 / ldap_mnesia / e6d3c4d dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e6d3c4d dynamic_domains_mysql_redis_26 / mysql_redis / e6d3c4d dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / e6d3c4d internal_mnesia_26 / internal_mnesia / e6d3c4d pgsql_cets_26 / pgsql_cets / e6d3c4d dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / e6d3c4d pgsql_mnesia_25 / pgsql_mnesia / e6d3c4d pgsql_mnesia_26 / pgsql_mnesia / e6d3c4d mysql_redis_26 / mysql_redis / e6d3c4d mssql_mnesia_26 / odbc_mssql_mnesia / e6d3c4d |
This PR splits the
Options: Listen
section of the documentation into multiple files, one for each of: general options, C2S, S2S, XMPP Components and HTTP listeners.It also fixes small issues I found when reviewing the docs, like typos, warnings, missing links.