Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4.0.0 dropped ESLint v8 support #89

Closed
aarongoldenthal opened this issue Jul 29, 2023 · 4 comments · Fixed by #92
Closed

v4.0.0 dropped ESLint v8 support #89

aarongoldenthal opened this issue Jul 29, 2023 · 4 comments · Fixed by #92
Labels
released

Comments

@aarongoldenthal
Copy link

aarongoldenthal commented Jul 29, 2023 •
edited
Loading

In #18, support for ESLint v4 and v5 was dropped (the intent per the PR). The change leaves only "peerDependencies": { "eslint": "^6.0.0 || ^7.0.0" }, so also dropped ESLint v8 support.
@silverwind
Copy link

Yep, can no longer install it on v8:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found: eslint@8.46.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"8.46.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^6.0.0 || ^7.0.0" from @eslint-community/eslint-plugin-eslint-comments@4.0.0
npm ERR! node_modules/@eslint-community/eslint-plugin-eslint-comments
npm ERR!   dev @eslint-community/eslint-plugin-eslint-comments@"4.0.0" from the root project

@silverwind silverwind mentioned this issue Jul 30, 2023
Merged
silverwind added a commit to go-gitea/gitea that referenced this issue Jul 30, 2023
@silverwind
Update js and py dependencies (#26243)
8e644d3 
- Update all JS and PY dependencies minus
`eslint-plugin-eslint-comments` (because of
eslint-community/eslint-plugin-eslint-comments#89)
- Regenerate SVGs
- Remove depreacted eslint rule
- Tested mermaid and swagger
@ota-meshi
Copy link
Member

@MichaelDeBoey This is the effect of change #18.
It was still supposed to be an alpha release and v4 was supposed to contain the #20 changes, but #20 was closed and v4 was released first.
We should merge #91 and open a pull request to support ESLint v8.

@MichaelDeBoey
Copy link
Member

@aarongoldenthal @silverwind ESLint v8 was never officially supported (we had no tests for it), but indeed something that we should support asap as technically there are no changes needed to support it

@MichaelDeBoey MichaelDeBoey mentioned this issue Jul 31, 2023
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support ESLint 8.x eslint-community/eslint-plugin-eslint-comments
4 participants
@silverwind @aarongoldenthal @MichaelDeBoey @ota-meshi