Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: test on eslint v8 (fixes #175) #186

Merged
merged 7 commits into from
Oct 11, 2021
Merged

Conversation

aladdin-add
Copy link
Contributor

No description provided.

@bmish
Copy link
Member

bmish commented Sep 24, 2021

Upgrading eslint-plugin-unicorn should fix this since I believe they were previously accessing APIs that are no longer public in ESLint 8: #187

"eslint-config-not-an-aardvark": "^2.1.0",
"eslint-plugin-markdown": "^2.0.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-self": "^1.2.1",
"eslint-plugin-unicorn": "^36.0.0",
"eslint-plugin-unicorn": "github:fisker/eslint-plugin-unicorn#eslint-8",
Copy link
Contributor Author

@aladdin-add aladdin-add Sep 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: replace the fork once it get merged and released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can proceed with this fork for now:

  • Most importantly, eslint-plugin-unicorn is an internal-only dev-dependency, and we shouldn't let a non-essential dev-dependency that has no public-facing impact to our consumers block us from releasing our plugin
  • The fork is owned by the maintainer of eslint-plugin-unicorn
  • We can pin to a specific commit of the fork branch if desired
  • Other repositories are using this fork to unblock themselves while awaiting for the official fix to be released

Related: platinumazure/eslint-plugin-qunit#209

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine, let's do it!

@aladdin-add
Copy link
Contributor Author

just pushed a commit db7131e to upgrade dev deps: espree & eslint-scope.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
@aladdin-add aladdin-add marked this pull request as ready for review October 11, 2021 02:17
@aladdin-add aladdin-add merged commit ac87852 into master Oct 11, 2021
@MichaelDeBoey MichaelDeBoey deleted the support-eslint-v8 branch September 10, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants