breaking: drop eslint < 7 & node.js < 10

[MichaelDeBoey]

ESLint v7.0.0 is released 🎉

devDependencies should be compatible with ESLint 7 too before we can merge this one:

• eslint-plugin-node (Support ESLint 7.x mysticatea/eslint-plugin-node#223)
  • chore(CI): add tests for ESLint 7 mysticatea/eslint-plugin-node#224
  • Release

---

BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x

Closes #94

[MichaelDeBoey]

@not-an-aardvark Since all tests are green for ESLint 7.x, I think we can merge this one without mysticatea/eslint-plugin-node#224 being merged 🙂

[aladdin-add]

LGTM, thanks!

[MichaelDeBoey]

@aladdin-add Any idea when this can be merged and released?

[xjamundx]

By this weekend?

…

On Wed, Apr 7, 2021 at 9:20 AM Michaël De Boey ***@***.***> wrote: @aladdin-add <https://github.com/aladdin-add> Any idea when this can be merged and released? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB4C7ZD3DYC5FR5HCVKLILTHSA4JANCNFSM4M4RDZQQ> .

[aladdin-add]

will have to wait @not-an-aardvark to do a new release, I don't have the access to publish to npm:)

it was written "eslint": ">=5.0.0", so the latest eslint-plugin-eslint-plugin has already supported the latest eslint(7.x). is it blocking something else?

[aladdin-add]

I've reedited the title, as it is a breaking change. :)

[not-an-aardvark]

@aladdin-add I just gave you publish access on npm, feel free to publish when you think it's appropriate.

[aladdin-add]

released in https://www.npmjs.com/package/eslint-plugin-eslint-plugin/v/3.0.0

[ljharb]

Dropping eslint < 7 is very unfortunate, since it means eslint plugins (which often depend on multiple versions of eslint, including the previous major) can't use it without getting npm7 peer deps.

eslint-plugin-react is stuck on v2 of this plugin for effectively ever, unless eslint 6 compat, at least, can be restored.

[aladdin-add]

a workaround is to use the --legacy-peer-deps.

oc, it seems no harm to restore the eslint v6 compat. will try to release a new version later.👍

[ljharb]

Yes, that is indeed what I'm using :-) and thank you, that would be most helpful.

[aladdin-add]

released in v3.5.2. 😄