-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update globals
+ update configs
#20
Conversation
Codecov ReportBase: 97.17% // Head: 97.17% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## alpha #20 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 39 39
Lines 390 390
=======================================
Hits 379 379
Misses 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@eslint-community/eslint-tsc @eslint-community/core-team @eslint-community/mysticatea-eslint-plugin Since this plugin is adhering the same semantic versioning policy as ESLint, adding new rules to a plugin would be a breaking change, so this PR would need to be released in a major release I guess? |
@ota-meshi What do you think we should do regarding breaking changes/releases? |
If we follow the policy, I think we need a major version release. |
5a5fe70
to
3e8c1e8
Compare
globals
+ update configsglobals
in +browser
& es*
configs
BREAKING CHANGE: `+browser`, `es5`, `es2015`, `es2016`, `es2017`, `es2018`, `es2019`, `es2020`, `es2021` & `es2022` configs will now report more globals as `readonly`
globals
in +browser
& es*
configsglobals
+ update configs
3e8c1e8
to
c5cffea
Compare
🎉 This PR is included in version 15.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 15.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 15.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Re-submission of mysticatea#38
BREAKING CHANGE:
+browser
,es5
,es2015
,es2016
,es2017
,es2018
,es2019
,es2020
,es2021
&es2022
configs will now report more globals asreadonly