Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update eslint-plugin-eslint-plugin + update configs #23

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Oct 16, 2022

Re-submission of mysticatea#41


BREAKING CHANGE: +eslint-plugin config now has extra rules from eslint-plugin-eslint-plugin

@MichaelDeBoey MichaelDeBoey requested a review from a team October 16, 2022 18:27
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Base: 97.17% // Head: 97.17% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5a94cbf) compared to base (0f90860).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha      #23      +/-   ##
==========================================
- Coverage   97.17%   97.17%   -0.01%     
==========================================
  Files          39       39              
  Lines         390      389       -1     
==========================================
- Hits          379      378       -1     
  Misses         11       11              
Impacted Files Coverage Δ
lib/configs/+eslint-plugin.js 100.00% <ø> (ø)
lib/rules/arrow-parens.js 100.00% <ø> (ø)
lib/rules/block-scoped-var.js 98.64% <ø> (ø)
lib/rules/no-instanceof-array.js 93.33% <ø> (ø)
lib/rules/no-instanceof-wrapper.js 100.00% <ø> (ø)
lib/rules/no-literal-call.js 100.00% <ø> (ø)
lib/rules/no-this-in-static.js 100.00% <ø> (ø)
lib/rules/no-use-ignored-vars.js 100.00% <ø> (ø)
lib/rules/no-useless-rest-spread.js 94.87% <ø> (ø)
lib/rules/prefer-for-of.js 99.20% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichaelDeBoey
Copy link
Member Author

@eslint-community/eslint-tsc @eslint-community/core-team @eslint-community/mysticatea-eslint-plugin Since this plugin is adhering the same semantic versioning policy as ESLint, adding new rules to a plugin would be a breaking change, so this PR would need to be released in a major release I guess?

@MichaelDeBoey MichaelDeBoey requested review from a team October 16, 2022 18:54
@MichaelDeBoey MichaelDeBoey marked this pull request as draft October 16, 2022 18:55
package.json Outdated Show resolved Hide resolved
@mdjermanovic
Copy link
Member

adding new rules to a plugin would be a breaking change

I assume you mean adding new rules to configs exported from the plugin. I agree that should be a breaking change.

@MichaelDeBoey
Copy link
Member Author

I assume you mean adding new rules to configs exported from the plugin

@mdjermanovic That's indeed what I meant 👍

@eslint-community/mysticatea-eslint-plugin I decided to make all the current outstanding PRs a breaking change & merge them into an alpha branch, so we can have 1 major release instead of one for every merged PR

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

BREAKING CHANGE: `+eslint-plugin` config now has extra rules from `eslint-plugin-eslint-plugin`
@github-actions
Copy link

🎉 This PR is included in version 15.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 15.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 15.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants