fix: move fetch to node-builtins && add more tests

Signed-off-by: 唯然 <weiran.zsd@outlook.com>
eslint-community · Apr 29, 2024 · c19ab39 · c19ab39
1 parent c008135
commit c19ab39
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 9 deletions.
diff --git a/lib/rules/no-unsupported-features/es-builtins.js b/lib/rules/no-unsupported-features/es-builtins.js
@@ -601,9 +601,6 @@ const traceMap = {
             trace: { [READ]: { supported: ["0.10.0"] } },
             warn: { [READ]: { supported: ["0.10.0"] } },
         },
-        fetch: {
-            [READ]: { supported: ["18.0.0"] },
-        },
         queueMicrotask: {
             [READ]: { supported: ["11.0.0"] },
         },

diff --git a/lib/rules/no-unsupported-features/node-builtins.js b/lib/rules/no-unsupported-features/node-builtins.js
@@ -31,6 +31,9 @@ const traceMap = {
                 paths: { [READ]: { supported: ["8.9.0"] } },
             },
         },
+        fetch: {
+            [READ]: { supported: ["18.0.0"] },
+        },
     },
     modules: NodeBuiltinModules,
 }

diff --git a/tests/lib/rules/no-unsupported-features/node-builtins.js b/tests/lib/rules/no-unsupported-features/node-builtins.js
@@ -5305,12 +5305,6 @@ new RuleTester({ languageOptions: { sourceType: "module" } }).run(
                         node: { version: "12.11.0" },
                     },
                 },
-
-                // https://github.com/eslint-community/eslint-plugin-n/issues/253
-                {
-                    code: `fetch("/api/xxx");`,
-                    settings: { node: { version: ">=18.2.0" } },
-                },
             ],
             invalid: [
                 {
@@ -5373,5 +5367,59 @@ new RuleTester({ languageOptions: { sourceType: "module" } }).run(
                 },
             ],
         },
+
+        //----------------------------------------------------------------------
+        // fetch
+        //----------------------------------------------------------------------
+        {
+            valid: [
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: ">=18.2.0" }],
+                },
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: ">=18.0.0" }],
+                },
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: "^18.0.0" }],
+                },
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: ">18.0.0" }],
+                },
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: ">=19.0.0" }],
+                },
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: ">19.0.0" }],
+                },
+            ],
+            invalid: [
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: ">=17.0.0" }],
+                    errors: [{ messageId: "not-supported-till" }],
+                },
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: "^17.0.0" }],
+                    errors: [{ messageId: "not-supported-till" }],
+                },
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: "^17.2.0" }],
+                    errors: [{ messageId: "not-supported-till" }],
+                },
+                {
+                    code: `fetch("/api/xxx");`,
+                    options: [{ version: "^17.2.0||18.x" }],
+                    errors: [{ messageId: "not-supported-till" }],
+                },
+            ],
+        },
     ])
 )