fix: unsupported-features/node-builtins-modules range compare (#252)

fixes #250 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
eslint-community · Apr 24, 2024 · d50ae85 · d50ae85
1 parent eb11b5b
commit d50ae85
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/util/check-unsupported-builtins.js b/lib/util/check-unsupported-builtins.js
@@ -9,6 +9,7 @@ const { ReferenceTracker } = require("@eslint-community/eslint-utils")
 const getConfiguredNodeVersion = require("./get-configured-node-version")
 const getSemverRange = require("./get-semver-range")
 const unprefixNodeColon = require("./unprefix-node-colon")
+const semverRangeSubset = require("semver/ranges/subset")
 
 /**
  * Parses the options.
@@ -50,7 +51,7 @@ function isSupported({ supported }, configured) {
         return false
     }
 
-    return configured.intersects(range)
+    return semverRangeSubset(configured, range)
 }
 
 /**

diff --git a/tests/lib/rules/no-unsupported-features/es-builtins.js b/tests/lib/rules/no-unsupported-features/es-builtins.js
@@ -2424,6 +2424,23 @@ runTests([
                     },
                 ],
             },
+            // https://github.com/eslint-community/eslint-plugin-n/issues/250
+            {
+                code: "function wrap() { globalThis }",
+                settings: {
+                    node: { version: ">=11.9.9" },
+                },
+                errors: [
+                    {
+                        messageId: "not-supported-till",
+                        data: {
+                            name: "globalThis",
+                            supported: "12.0.0",
+                            version: ">=11.9.9",
+                        },
+                    },
+                ],
+            },
         ],
     },
 ])