Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint >=9.0.0-beta.1 in peer dependency #197

Closed
1 task done
voxpelli opened this issue Mar 4, 2024 · 6 comments · Fixed by #200
Closed
1 task done

Support ESLint >=9.0.0-beta.1 in peer dependency #197

voxpelli opened this issue Mar 4, 2024 · 6 comments · Fixed by #200
Assignees

Comments

@voxpelli
Copy link
Member

voxpelli commented Mar 4, 2024

eslint-plugin-n version

17.0.0-3

What problem do you want to solve?

At a minimal: The range >=7.0.0 does not include prerelease versions, so it complains when installing this module currently.

What do you think is the correct solution?

We would need to add || >= 9.0.0-beta.1 to the eslint peer dependency (but before that there's maybe something we need to do to adapt to ESLint 9? I didn't find an issue for that)

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

@aladdin-add
Copy link

which package manager are you using?

For npm>=7, it will auto-install peer-dependencies, you can use --force or --legacy-deps.

@voxpelli
Copy link
Member Author

voxpelli commented Mar 4, 2024

@aladdin-add Yes, I'm using npm and I did use force to get around it for now

@voxpelli
Copy link
Member Author

voxpelli commented Mar 4, 2024

@aladdin-add I guess bigger question is: Are we aiming at supporting ESLint 9.x yet?

@aladdin-add
Copy link

Yes, and it did. see

eslint: [8.x, "next"]

the issue is package managers like npm does not allow prereleases (e.g 9.0.0-beta.1) for eslint>=8.0.0.

@voxpelli
Copy link
Member Author

voxpelli commented Mar 4, 2024

Yeah, I remembered it was added somewhere but became unsure 👍

the issue is package managers like npm does not allow prereleases (e.g 9.0.0-beta.1) for eslint>=8.0.0.

Well, its a good thing they don't in most cases, only in the peer dependency field is it annoying

@voxpelli
Copy link
Member Author

Reopening as a sister ticket to eslint-community/eslint-utils#183 (comment)

We need to figure out how to set our peer dependency ranges to avoid this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants