-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ESLint >=9.0.0-beta.1 in peer dependency #197
Comments
which package manager are you using? For npm>=7, it will auto-install peer-dependencies, you can use |
@aladdin-add Yes, I'm using |
@aladdin-add I guess bigger question is: Are we aiming at supporting ESLint 9.x yet? |
Yes, and it did. see eslint-plugin-n/.github/workflows/CI.yml Line 36 in 4778ae8
the issue is package managers like npm does not allow prereleases (e.g |
Yeah, I remembered it was added somewhere but became unsure 👍
Well, its a good thing they don't in most cases, only in the peer dependency field is it annoying |
Reopening as a sister ticket to eslint-community/eslint-utils#183 (comment) We need to figure out how to set our peer dependency ranges to avoid this |
Fixes #197 using the solution from eslint-community/eslint-utils#206
Fixes #197 using the solution from eslint-community/eslint-utils#206
eslint-plugin-n version
17.0.0-3
What problem do you want to solve?
At a minimal: The range
>=7.0.0
does not include prerelease versions, so it complains when installing this module currently.What do you think is the correct solution?
We would need to add
|| >= 9.0.0-beta.1
to the eslint peer dependency (but before that there's maybe something we need to do to adapt to ESLint 9? I didn't find an issue for that)Participation
Additional comments
No response
The text was updated successfully, but these errors were encountered: