Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: False-positive in n/no-unsupported-features/node-builtins #234

Closed
1 task
TimShilov opened this issue Apr 10, 2024 · 1 comment · Fixed by #235, #233 or YoutacRandS-VA/datatracker#4 · May be fixed by junsulee/Anki-Android#1
Closed
1 task

Bug: False-positive in n/no-unsupported-features/node-builtins #234

TimShilov opened this issue Apr 10, 2024 · 1 comment · Fixed by #235, #233 or YoutacRandS-VA/datatracker#4 · May be fixed by junsulee/Anki-Android#1
Assignees
@scagood
Labels
accepted bug

Comments

@TimShilov
Copy link

Environment

Node version: 20.12.1
pnpm version: 8.15.6
ESLint version: 9.0.0
eslint-plugin-n version: 17.1.0
Operating System: MacOS 14.4.1

What rule do you want to report?

n/no-unsupported-features/node-builtins

Link to Minimal Reproducible Example

https://eslint-online-playground.netlify.app/#eNptkMFOwzAMhl8l8gmkrV13QeouHHgA7suQqtatMhInalI0VPXdcZIVNiAnJ/7+/3c8gx/bEi+NcRqLs4calHF2DGIWTjnUilAsoh+tERLIdlj7MGJjSsdPyqOXcJAkSUhqLXnLLtoOD6v28QAbQM9lKLjfq+EuJHdW++d8Lc+r6ZWKsa96GhStZAa3Lj1uKeF4SXCHfTPpII48E5+7bF+M2FpjkDrsNmlsPj/2K3aU0OsmlDe0hBMLTpzDH3JN+94McV+W+DNz9JEQPh1KqLkytps016yIjQ4/XtBFG2pV3FgtkiT28nxZxpHouU6y2LxdyL/Anz1EqnoqqmInIULLdQQkBn5Fx39nxdt+V1T7b42kBZYv8/y1ew==

What did you expect to happen?

The rule reports that stream/promises API is experimental in Node.js v20.12.0 and I'm not sure if that's correct.

The Node.js docs (https://nodejs.org/docs/latest-v20.x/api/stream.html#streams-promises-api) never mention it as experimental (and seems like they never did since it was added v15).

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@TimShilov TimShilov added the bug label Apr 10, 2024
@scagood
Copy link

scagood commented Apr 10, 2024

Yep, this sounds like a mistake! Thanks

scagood added a commit that referenced this issue Apr 10, 2024
@scagood
fix: stream/promises is stable
e72828d 
closes #234
@scagood scagood mentioned this issue Apr 10, 2024
Merged
@scagood scagood self-assigned this Apr 10, 2024
aladdin-add pushed a commit that referenced this issue Apr 10, 2024
@scagood
fix(no-unsupported-features): stream/promises is stable (#235)
02a264e 
fix: `stream/promises` is stable

closes #234
@github-actions github-actions bot mentioned this issue Apr 10, 2024
Merged
@lholmquist lholmquist mentioned this issue May 21, 2024
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
@YoutacRandS-VA YoutacRandS-VA mentioned this issue Jun 20, 2024
Merged
@junsulee junsulee mentioned this issue Jun 25, 2024
Open
@lholmquist lholmquist mentioned this issue Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scagood scagood

Labels
accepted bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(no-unsupported-features): stream/promises is stable eslint-community/eslint-plugin-n
chore(master): release 17.2.0 eslint-community/eslint-plugin-n
[Snyk] Upgrade eslint-plugin-n from 16.6.2 to 17.7.0 YoutacRandS-VA/datatracker
[Snyk] Upgrade eslint-plugin-n from 16.6.2 to 17.7.0 junsulee/Anki-Android
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.4.0 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.5.1 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.6.0 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.7.0 nodeshift/kube-service-bindings
[Snyk] Upgrade eslint-plugin-n from 16.0.2 to 17.8.0 nodeshift/kube-service-bindings
2 participants
@scagood @TimShilov