Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-missing-import): Add ignoreTypeImport options #344

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

scagood
Copy link

@scagood scagood commented Sep 25, 2024

Adds the ability to ignore type imports on no-missing-import

Closes #286

@scagood scagood changed the title feat: Add ignoreTypeImport to no-missing-import feat(no-missing-import): Add ignoreTypeImport options Sep 25, 2024
@scagood scagood requested review from a team and aladdin-add September 25, 2024 21:18
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs needs to be updated, otherwise LGTM. 👍

Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit e022aba into eslint-community:master Oct 9, 2024
23 checks passed
@scagood scagood deleted the issue-286 branch October 9, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: import type fails with no-missing-import if node fails to resolve the import
2 participants