Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-deprecated-api): dedeprecate process.nextTick #350

Conversation

mcollina
Copy link

@mcollina mcollina commented Oct 9, 2024

I've recently noticed that this module is starting to tag process.nextTick() as deprecated. But it's not. Essentially it's close to impossible to stop using for old code, because it will alter the order of callbacks being fired.

Here is the full discussion: nodejs/node#51280. Note that Node.js still uses it everywhere, because it's not possible to replace it without breaking a lot of people.

image

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@MichaelDeBoey MichaelDeBoey changed the title process.nextTick was not deprecated fix(no-deprecated-api): dedeprecate process.nextTick Oct 9, 2024
@MichaelDeBoey MichaelDeBoey added the rule:update An update to a current rule label Oct 9, 2024
@scagood
Copy link

scagood commented Oct 9, 2024

This was a misunderstanding on my part, Sorry!

Thank you for the PR

@scagood scagood added the bug label Oct 9, 2024
@MichaelDeBoey MichaelDeBoey merged commit dd889ab into eslint-community:master Oct 9, 2024
23 checks passed
@scagood
Copy link

scagood commented Oct 9, 2024

The PR at fault #342, the specific commit: 37c6bf1 (#342)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rule:update An update to a current rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants